Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2548253004: Add profiling, integrate into Butler/Annotee. (Closed)

Created:
4 years ago by dnj
Modified:
4 years ago
Reviewers:
martiniss
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Add profiling, integrate into Butler/Annotee. Add a profiling package to run a profiling HTTP server and allow periodic profiling metric collection. Integrate this into LogDog's Annotee and Butler programs. BUG=chromium:671616 TEST=local - Ran Butler locally, bound to HTTP server, seems to work. Committed: https://github.com/luci/luci-go/commit/f5e96b94465d190bb8022c900506e17e7c5e1a70

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -12 lines) Patch
A common/runtime/profiling/profiler.go View 1 chunk +160 lines, -0 lines 0 comments Download
M logdog/client/cmd/logdog_annotee/main.go View 4 chunks +12 lines, -0 lines 0 comments Download
M logdog/client/cmd/logdog_butler/main.go View 6 chunks +8 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
dnj
PTAL Sorry this took so long, got caught up in profiling :)
4 years ago (2016-12-06 20:25:20 UTC) #2
martiniss
lgtm, but I don't see any instructions on use of this anywhere.. :(
4 years ago (2016-12-06 20:36:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548253004/1
4 years ago (2016-12-06 20:43:13 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-06 20:49:53 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/f5e96b94465d190bb8022c900506e17e7c5e1a70

Powered by Google App Engine
This is Rietveld 408576698