Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: test/cctest/test-conversions.cc

Issue 2548243004: Return false in TryNumberToSize if there is a cast error (Closed)
Patch Set: Return false in TryNumberToSize if the number is 1 << 64. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/conversions-inl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 426 matching lines...) Expand 10 before | Expand all | Expand 10 after
437 CHECK_EQ(result, 2u); 437 CHECK_EQ(result, 2u);
438 } 438 }
439 Handle<HeapNumber> heap_number2 = isolate->factory()->NewHeapNumber( 439 Handle<HeapNumber> heap_number2 = isolate->factory()->NewHeapNumber(
440 static_cast<double>(std::numeric_limits<size_t>::max()) + 10000.0); 440 static_cast<double>(std::numeric_limits<size_t>::max()) + 10000.0);
441 { 441 {
442 SealHandleScope no_handles(isolate); 442 SealHandleScope no_handles(isolate);
443 CHECK(!TryNumberToSize(*heap_number2, &result)); 443 CHECK(!TryNumberToSize(*heap_number2, &result));
444 } 444 }
445 } 445 }
446 } 446 }
447
448 TEST(TryNumberToSizeWithMaxSizePlusOne) {
449 i::Isolate* isolate = CcTest::i_isolate();
450 {
451 HandleScope scope(isolate);
452 // 1 << 64, larger than the limit of size_t.
453 double value = 18446744073709551616.0;
454 size_t result = 0;
455 Handle<HeapNumber> heap_number = isolate->factory()->NewHeapNumber(value);
456 CHECK(!TryNumberToSize(*heap_number, &result));
457 }
458 }
OLDNEW
« no previous file with comments | « src/conversions-inl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698