Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 254823007: Make DOMError constructible (Closed)

Created:
6 years, 8 months ago by Inactive
Modified:
6 years, 7 months ago
CC:
blink-reviews, chrishtr, arv+blink, eae+blinkwatch, ojan, dglazkov+blink, adamk+blink_chromium.org, rwlbuis, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Make DOMError constructible Make DOMError constructible as per the DOM4 specification: http://dom.spec.whatwg.org/#domerror This matches the behavior of Firefox 28. IE11 exposes DOMError on the global Window object but it is not constructible. R=arv@chromium.org, tkent@chromium.org BUG=367565 TEST=fast/dom/DOMError-constructor.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172718

Patch Set 1 #

Patch Set 2 : Rebaseline additional test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -2 lines) Patch
A LayoutTests/fast/dom/DOMError-constructor.html View 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/DOMError-constructor-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-constructors-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/DOMError.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Inactive
6 years, 8 months ago (2014-04-27 21:15:18 UTC) #1
tkent
lgtm
6 years, 8 months ago (2014-04-28 01:42:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/254823007/20001
6 years, 8 months ago (2014-04-28 01:42:52 UTC) #3
haraken
LGTM
6 years, 8 months ago (2014-04-28 01:43:39 UTC) #4
commit-bot: I haz the power
Change committed as 172718
6 years, 8 months ago (2014-04-28 01:48:12 UTC) #5
Inactive
On 2014/04/28 01:48:12, I haz the power (commit-bot) wrote: > Change committed as 172718 Looks ...
6 years, 8 months ago (2014-04-28 02:05:22 UTC) #6
sof
On 2014/04/28 02:05:22, Chris Dumez wrote: > On 2014/04/28 01:48:12, I haz the power (commit-bot) ...
6 years, 7 months ago (2014-04-28 05:22:00 UTC) #7
Inactive
On 2014/04/28 05:22:00, sof wrote: > On 2014/04/28 02:05:22, Chris Dumez wrote: > > On ...
6 years, 7 months ago (2014-04-28 13:20:03 UTC) #8
arv (Not doing code reviews)
6 years, 7 months ago (2014-04-28 13:54:11 UTC) #9
Message was sent while issue was closed.
LGTM

Since this adds no extra code and we do use DOMError in a few places it makes
sense to fix this.

Powered by Google App Engine
This is Rietveld 408576698