Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 254823005: Move android Telephony APIs to from content/ to net/. (Closed)

Created:
6 years, 8 months ago by bolian
Modified:
6 years, 7 months ago
Reviewers:
Charlie Reis, Yaron, mef
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move android Telephony APIs from content/ to net/. This is needed for logging operator code in net/. See https://codereview.chromium.org/246553003/ BUG=355604 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267437

Patch Set 1 #

Patch Set 2 : sync'ed to head & resolved conflicts #

Patch Set 3 : NET_EXPORT the moved APIs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -155 lines) Patch
M content/common/android/common_jni_registrar.cc View 1 chunk +0 lines, -3 lines 0 comments Download
D content/common/android/device_telephony_info.h View 1 chunk +0 lines, -41 lines 0 comments Download
D content/common/android/device_telephony_info.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M content/content_common.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_jni.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D content/public/android/java/src/org/chromium/content/common/DeviceTelephonyInfo.java View 1 chunk +0 lines, -58 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 chunks +2 lines, -4 lines 0 comments Download
M net/android/java/src/org/chromium/net/AndroidNetworkLibrary.java View 1 2 2 chunks +29 lines, -0 lines 0 comments Download
M net/android/network_library.h View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M net/android/network_library.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (0 generated)
bolian
Hello Yaron and Misha, I need to move the GetNetworkOperator API to net/. I also ...
6 years, 7 months ago (2014-04-28 22:48:20 UTC) #1
Yaron
lgtm
6 years, 7 months ago (2014-04-29 04:07:26 UTC) #2
mef
lgtm with nit: fix the description typo 'to from content/ to net/'.
6 years, 7 months ago (2014-04-29 15:31:31 UTC) #3
bolian
Done. Thanks!
6 years, 7 months ago (2014-04-29 17:06:56 UTC) #4
bolian
The CQ bit was checked by bolian@chromium.org
6 years, 7 months ago (2014-04-29 17:07:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bolian@chromium.org/254823005/1
6 years, 7 months ago (2014-04-29 17:08:13 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 17:08:34 UTC) #7
commit-bot: I haz the power
Failed to apply patch for content/content_common.gypi: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 7 months ago (2014-04-29 17:08:34 UTC) #8
bolian
Hi Charlie, Could you take a look at content/renderer/render_view_impl.cc for permission? Thanks, Bolian
6 years, 7 months ago (2014-04-29 17:22:54 UTC) #9
Charlie Reis
render_view_impl.cc LGTM
6 years, 7 months ago (2014-04-29 21:16:01 UTC) #10
bolian
The CQ bit was checked by bolian@chromium.org
6 years, 7 months ago (2014-04-29 21:16:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bolian@chromium.org/254823005/20001
6 years, 7 months ago (2014-04-29 21:19:12 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 21:35:21 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium
6 years, 7 months ago (2014-04-29 21:35:22 UTC) #14
bolian
The CQ bit was checked by bolian@chromium.org
6 years, 7 months ago (2014-04-30 17:43:35 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bolian@chromium.org/254823005/20001
6 years, 7 months ago (2014-04-30 17:46:12 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 18:04:49 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium
6 years, 7 months ago (2014-04-30 18:04:50 UTC) #18
bolian
The CQ bit was checked by bolian@chromium.org
6 years, 7 months ago (2014-04-30 20:51:42 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bolian@chromium.org/254823005/20001
6 years, 7 months ago (2014-04-30 20:52:32 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 21:13:11 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium
6 years, 7 months ago (2014-04-30 21:13:12 UTC) #22
bolian
The CQ bit was checked by bolian@chromium.org
6 years, 7 months ago (2014-04-30 22:06:07 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bolian@chromium.org/254823005/40001
6 years, 7 months ago (2014-04-30 22:06:42 UTC) #24
commit-bot: I haz the power
6 years, 7 months ago (2014-05-01 05:10:10 UTC) #25
Message was sent while issue was closed. 
Change committed as 267437

Powered by Google App Engine
This is Rietveld 408576698