Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1996)

Side by Side Diff: src/libplatform/default-platform.cc

Issue 254823002: Revert 20962 "Break cyclic reference between utils and platform." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/libplatform/default-platform.h ('k') | src/platform.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 #include "default-platform.h" 28 #include "default-platform.h"
29 29
30 #include <algorithm>
31 #include <queue> 30 #include <queue>
32 31
33 // TODO(jochen): We should have our own version of checks.h. 32 // TODO(jochen): We should have our own version of checks.h.
34 #include "../checks.h" 33 #include "../checks.h"
35 // TODO(jochen): Why is cpu.h not in platform/? 34 // TODO(jochen): Why is cpu.h not in platform/?
36 #include "../cpu.h" 35 #include "../cpu.h"
37 #include "worker-thread.h" 36 #include "worker-thread.h"
38 37
39 namespace v8 { 38 namespace v8 {
40 namespace internal { 39 namespace internal {
41 40
42 41
43 const int DefaultPlatform::kMaxThreadPoolSize = 4;
44
45
46 DefaultPlatform::DefaultPlatform() 42 DefaultPlatform::DefaultPlatform()
47 : initialized_(false), thread_pool_size_(0) {} 43 : initialized_(false), thread_pool_size_(0) {}
48 44
49 45
50 DefaultPlatform::~DefaultPlatform() { 46 DefaultPlatform::~DefaultPlatform() {
51 LockGuard<Mutex> guard(&lock_); 47 LockGuard<Mutex> guard(&lock_);
52 queue_.Terminate(); 48 queue_.Terminate();
53 if (initialized_) { 49 if (initialized_) {
54 for (std::vector<WorkerThread*>::iterator i = thread_pool_.begin(); 50 for (std::vector<WorkerThread*>::iterator i = thread_pool_.begin();
55 i != thread_pool_.end(); ++i) { 51 i != thread_pool_.end(); ++i) {
56 delete *i; 52 delete *i;
57 } 53 }
58 } 54 }
59 } 55 }
60 56
61 57
62 void DefaultPlatform::SetThreadPoolSize(int thread_pool_size) { 58 void DefaultPlatform::SetThreadPoolSize(int thread_pool_size) {
63 LockGuard<Mutex> guard(&lock_); 59 LockGuard<Mutex> guard(&lock_);
64 ASSERT(thread_pool_size >= 0); 60 ASSERT(thread_pool_size >= 0);
65 if (thread_pool_size < 1) 61 if (thread_pool_size < 1)
66 thread_pool_size = CPU::NumberOfProcessorsOnline(); 62 thread_pool_size = CPU::NumberOfProcessorsOnline();
67 thread_pool_size_ = 63 thread_pool_size_ = Max(Min(thread_pool_size, kMaxThreadPoolSize), 1);
68 std::max(std::min(thread_pool_size, kMaxThreadPoolSize), 1);
69 } 64 }
70 65
71 66
72 void DefaultPlatform::EnsureInitialized() { 67 void DefaultPlatform::EnsureInitialized() {
73 LockGuard<Mutex> guard(&lock_); 68 LockGuard<Mutex> guard(&lock_);
74 if (initialized_) return; 69 if (initialized_) return;
75 initialized_ = true; 70 initialized_ = true;
76 71
77 for (int i = 0; i < thread_pool_size_; ++i) 72 for (int i = 0; i < thread_pool_size_; ++i)
78 thread_pool_.push_back(new WorkerThread(&queue_)); 73 thread_pool_.push_back(new WorkerThread(&queue_));
79 } 74 }
80 75
81 void DefaultPlatform::CallOnBackgroundThread(Task *task, 76 void DefaultPlatform::CallOnBackgroundThread(Task *task,
82 ExpectedRuntime expected_runtime) { 77 ExpectedRuntime expected_runtime) {
83 EnsureInitialized(); 78 EnsureInitialized();
84 queue_.Append(task); 79 queue_.Append(task);
85 } 80 }
86 81
87 82
88 void DefaultPlatform::CallOnForegroundThread(v8::Isolate* isolate, Task* task) { 83 void DefaultPlatform::CallOnForegroundThread(v8::Isolate* isolate, Task* task) {
89 // TODO(jochen): implement. 84 // TODO(jochen): implement.
90 task->Run(); 85 task->Run();
91 delete task; 86 delete task;
92 } 87 }
93 88
94 } } // namespace v8::internal 89 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/libplatform/default-platform.h ('k') | src/platform.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698