src/wasm/wasm-module.cc - Issue 2548223002: [wasm] Update WasmMemoryObject correctly when module memory is exported.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/wasm/wasm-module.cc

Issue 2548223002: [wasm] Update WasmMemoryObject correctly when module memory is exported. (Closed)

Patch Set: Add export-grow test in import-memory.js Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/wasm/wasm-module.cc

diff --git a/src/wasm/wasm-module.cc b/src/wasm/wasm-module.cc

index f0598556b4838f9606108e7f4298b6968da72d50..f57a1dd7b981d58bcdbb454f506dd13c50f961d3 100644

--- a/src/wasm/wasm-module.cc

+++ b/src/wasm/wasm-module.cc

@@ -1794,7 +1794,6 @@ class WasmInstanceBuilder {

memory_object = WasmMemoryObject::New(

isolate_, buffer,

(module_->max_mem_pages != 0) ? module_->max_mem_pages : -1);

- instance->set_memory_object(*memory_object);

} else {

memory_object = Handle<WasmMemoryObject>(

instance->get_memory_object(), isolate_);