Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 2548213002: Move quic_socket_utils to platform/impl/ (Closed)

Created:
4 years ago by Ryan Hamilton
Modified:
4 years ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move quic_socket_utils to platform/impl/ Merge internal change: 139645673 BUG= Committed: https://crrev.com/33a6ce8b746a3a1ba1515505df2163e503cf98c9 Cr-Commit-Position: refs/heads/master@{#436656}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -462 lines) Patch
M net/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +1 line, -1 line 0 comments Download
A + net/tools/quic/platform/impl/quic_socket_utils.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + net/tools/quic/platform/impl/quic_socket_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_default_packet_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_epoll_connection_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_packet_reader.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_packet_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_server.cc View 2 chunks +1 line, -1 line 0 comments Download
D net/tools/quic/quic_socket_utils.h View 1 chunk +0 lines, -132 lines 0 comments Download
D net/tools/quic/quic_socket_utils.cc View 1 chunk +0 lines, -316 lines 0 comments Download
M net/tools/quic/test_tools/packet_dropping_test_writer.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
Ryan Hamilton
4 years ago (2016-12-04 16:55:23 UTC) #2
Zhongyi Shi
lgtm
4 years ago (2016-12-05 07:30:04 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 2547233002 Patch 1). Please resolve the dependency and ...
4 years ago (2016-12-05 07:30:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548213002/1
4 years ago (2016-12-06 17:40:58 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 18:42:11 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-06 18:48:16 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33a6ce8b746a3a1ba1515505df2163e503cf98c9
Cr-Commit-Position: refs/heads/master@{#436656}

Powered by Google App Engine
This is Rietveld 408576698