Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2548173002: Fuchsia: Adds a script to make a jiri manifest for third_party/pkg stuff (Closed)

Created:
4 years ago by zra
Modified:
3 years, 11 months ago
Reviewers:
abarth, P.Y.L., siva
CC:
abarth, phosek, P.Y.L., reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fuchsia: Adds a script to make a jiri manifest for third_party/pkg stuff Building the Observatory and the full SDK requires the third_party Dart packages that we DEPS into a standalone SDK checkout. Fuchsia uses jiri manifests rather than DEPS files, so this CL adds a script that translates the DEPS for third_party/pkg stuff into a jiri manifest. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/571bbaade00f2bc5ff7a4395908d845da7f934fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -0 lines) Patch
A tools/create_pkg_manifest.py View 1 chunk +108 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
zra
4 years ago (2016-12-04 07:35:02 UTC) #2
abarth
Awesome. Thanks for doing this!
4 years ago (2016-12-04 07:39:54 UTC) #4
siva
lgtm
4 years ago (2016-12-06 20:47:05 UTC) #5
zra
Committed patchset #1 (id:1) manually as 571bbaade00f2bc5ff7a4395908d845da7f934fc (presubmit successful).
4 years ago (2016-12-06 21:45:29 UTC) #7
P.Y.L.
3 years, 11 months ago (2017-01-05 23:22:40 UTC) #9
Message was sent while issue was closed.
Late to the party, but that was a very cool addition!

Powered by Google App Engine
This is Rietveld 408576698