Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2548063002: [tracing] Show the local storage databases under dom_storage (Closed)

Created:
4 years ago by ssid
Modified:
4 years ago
Reviewers:
michaeln, DmitrySkiba
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tracing] Show the local storage databases under dom_storage The sqlite memory usage was being reported under "sqlite" column. After this CL the sql databases opened by DOM storage will be shown under the "dom_storage" column. This is done by adding an ownership edge (implemented in sql::Connection::ReportMemoryUsage). BUG=605785 Committed: https://crrev.com/9270bd2a45d85f4810cafedc6f25e188edf2d671 Cr-Commit-Position: refs/heads/master@{#437426}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add IsOpen. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -1 line) Patch
M content/browser/dom_storage/dom_storage_area.cc View 2 chunks +5 lines, -1 line 0 comments Download
M content/browser/dom_storage/dom_storage_database.h View 3 chunks +11 lines, -0 lines 0 comments Download
M content/browser/dom_storage/dom_storage_database.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/dom_storage/dom_storage_database_adapter.h View 2 chunks +11 lines, -0 lines 0 comments Download
M content/browser/dom_storage/local_storage_database_adapter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/dom_storage/local_storage_database_adapter.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
ssid
ptal, thanks!
4 years ago (2016-12-03 01:08:47 UTC) #2
michaeln
https://codereview.chromium.org/2548063002/diff/1/content/browser/dom_storage/dom_storage_database.cc File content/browser/dom_storage/dom_storage_database.cc (right): https://codereview.chromium.org/2548063002/diff/1/content/browser/dom_storage/dom_storage_database.cc#newcode140 content/browser/dom_storage/dom_storage_database.cc:140: const std::string& name) { i think you need to ...
4 years ago (2016-12-05 22:42:53 UTC) #4
ssid
Thanks, fixed. ptal https://codereview.chromium.org/2548063002/diff/1/content/browser/dom_storage/dom_storage_database.cc File content/browser/dom_storage/dom_storage_database.cc (right): https://codereview.chromium.org/2548063002/diff/1/content/browser/dom_storage/dom_storage_database.cc#newcode140 content/browser/dom_storage/dom_storage_database.cc:140: const std::string& name) { On 2016/12/05 ...
4 years ago (2016-12-08 18:09:47 UTC) #5
michaeln
lgtm
4 years ago (2016-12-08 23:26:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548063002/20001
4 years ago (2016-12-09 00:31:31 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-09 01:57:32 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-09 02:01:08 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9270bd2a45d85f4810cafedc6f25e188edf2d671
Cr-Commit-Position: refs/heads/master@{#437426}

Powered by Google App Engine
This is Rietveld 408576698