Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2548033002: [Offline Pages] Adds storage for kInvalidOfflineId. (Closed)

Created:
4 years ago by dewittj
Modified:
4 years ago
Reviewers:
carlosk
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Adds storage for kInvalidOfflineId. Since kInvalidOfflineId is a static data member, it needs explicitly defined storage as soon as it becomes 'odr-used'. Replace a temporary variable in RecentTabHelper with storage in offline_page_model.cc both for clarity and to allow further references to kInvalidOfflineId to be taken. BUG= Committed: https://crrev.com/07cab6870842811b1b4bad01a69ead1a95acac33 Cr-Commit-Position: refs/heads/master@{#436116}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/android/offline_pages/recent_tab_helper.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/offline_pages/offline_page_model.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
dewittj
4 years ago (2016-12-02 23:50:41 UTC) #5
carlosk
LGTM and thanks for fixing this.
4 years ago (2016-12-03 01:05:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548033002/1
4 years ago (2016-12-03 01:06:11 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-03 01:16:18 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-03 01:20:55 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07cab6870842811b1b4bad01a69ead1a95acac33
Cr-Commit-Position: refs/heads/master@{#436116}

Powered by Google App Engine
This is Rietveld 408576698