Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 254803013: Add skyostil@ to tools/perf/OWNERS (Closed)

Created:
6 years, 7 months ago by Sami
Modified:
6 years, 7 months ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Visibility:
Public.

Description

Add skyostil@ to tools/perf/OWNERS NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266587

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/perf/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sami
6 years, 7 months ago (2014-04-28 16:09:26 UTC) #1
tonyg
lgtm
6 years, 7 months ago (2014-04-28 16:21:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/254803013/1
6 years, 7 months ago (2014-04-28 16:22:51 UTC) #3
commit-bot: I haz the power
Change committed as 266587
6 years, 7 months ago (2014-04-28 16:24:41 UTC) #4
tonyg
Oh, and I'm sure you have seen it, but please keep these reviewing guidelines in ...
6 years, 7 months ago (2014-04-28 16:32:26 UTC) #5
Sami
6 years, 7 months ago (2014-04-28 17:15:42 UTC) #6
Message was sent while issue was closed.
On 2014/04/28 16:32:26, tonyg wrote:
> Oh, and I'm sure you have seen it, but please keep these reviewing
> guidelines in mind:
> http://www.chromium.org/developers/telemetry/telemetry-feature-guidelines
> 
> Especially the bit about unittest coverage for everything. That part
> is really important because functional benchmark breakages don't close
> the tree or show up on the CQ, but Telemetry unittests do both. So it
> goes a long way to keeping our benchmarks working.

Thanks for the link. I definitely second the importance of testing in this area.
 
> -Tony

- Sami

> On Mon, Apr 28, 2014 at 9:24 AM,  <mailto:commit-bot@chromium.org> wrote:
> > Change committed as 266587
> >
> > https://codereview.chromium.org/254803013/
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698