Chromium Code Reviews

Unified Diff: chrome/test/data/webrtc/webrtc_video_quality_test.html

Issue 254803002: Making webrtc video quality test page generic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removing nits Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: chrome/test/data/webrtc/webrtc_video_quality_test.html
diff --git a/chrome/test/data/webrtc/webrtc_video_quality_test.html b/chrome/test/data/webrtc/webrtc_video_quality_test.html
index 258984dcf5e815d26ee345dce4652855c4f28dec..d48ea09fb9989087f2a7873f571720320c671f7e 100644
--- a/chrome/test/data/webrtc/webrtc_video_quality_test.html
+++ b/chrome/test/data/webrtc/webrtc_video_quality_test.html
@@ -9,7 +9,7 @@
<script type="text/javascript" src="jsep01_call.js"></script>
<script type="text/javascript" src="video_extraction.js"></script>
</head>
-<body>
+<body onload="initialize()">
<table border="0">
<tr>
<td>Local Preview</td>
@@ -17,8 +17,7 @@
</tr>
<tr>
<td>
- <video width="640" height="360" id="local-view"
- autoplay="autoplay"></video>
+ <video id="local-view" autoplay="autoplay"></video>
</td>
<td>
<!-- startFrameCapture() takes 5 parameters:
@@ -27,20 +26,18 @@
3. canvas_height: Height of the canvas.
4. fps: fps at which we would like to sample.
5. duration: The duration of the capturing. -->
- <video width="640" height="360" id="remote-view"
- autoplay="autoplay" onplay="startFrameCapture(640,360,360,30,5)">
- </video>
+ <video id="remote-view" autoplay="autoplay"
+ onplay="startFrameCapture('local-view', 30, 5)"></video>
phoglund_chromium 2014/04/28 11:20:54 Nit: indent should be 4 spaces here (like it was).
</td>
</tr>
<tr>
<td></td>
<td>
- <div id="output" style="display: inline-block;
- position: relative; width: 640; height: 360">
+ <div id="output">
<!-- Canvas height should be equal to video height if we want to
capture the whole frames. If we only want to capture the barcode,
canvas height should equal the barcode height. -->
- <canvas id="remote-canvas" width="640" height="360"></canvas>
+ <canvas id="remote-canvas"></canvas>
</div>
</td>
</tr>
« chrome/test/data/webrtc/video_extraction.js ('K') | « chrome/test/data/webrtc/video_extraction.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine