Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2548003002: Expose isPointInPath and isPointInStroke for OffscreenCanvas 2D (Closed)

Created:
4 years ago by xidachen
Modified:
4 years ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose isPointInPath and isPointInStroke for OffscreenCanvas 2D The implementation is already there, we just need to expose the APIs. This CL also adds layout tests to confirm the APIs' behavior. BUG=670860 Committed: https://crrev.com/28b6bf098c8c5fcb7f75568be3c66e0d2a24a4d0 Cr-Commit-Position: refs/heads/master@{#436342}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : update global interface layout tests results #

Messages

Total messages: 12 (7 generated)
xidachen
PTAL
4 years ago (2016-12-05 15:03:11 UTC) #2
Justin Novosad
lgtm
4 years ago (2016-12-05 15:45:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548003002/40001
4 years ago (2016-12-05 16:54:58 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-05 17:52:46 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-05 17:55:35 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/28b6bf098c8c5fcb7f75568be3c66e0d2a24a4d0
Cr-Commit-Position: refs/heads/master@{#436342}

Powered by Google App Engine
This is Rietveld 408576698