Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2547973002:
Enable Cardboard on Daydream ready device (Closed)
DescriptionEnable Cardboard support on Daydream ready device
BUG=671224
Committed: https://crrev.com/f5e72ebfb73d97c2d7175d2fb578c48006b66c22
Cr-Commit-Position: refs/heads/master@{#436420}
Patch Set 1 #Patch Set 2 : Nit #
Total comments: 2
Patch Set 3 : review #Patch Set 4 : Add default #
Messages
Total messages: 27 (20 generated)
Description was changed from ========== Allow Cardboard BUG= ========== to ========== Enable Cardboard support on Daydream ready device BUG= ==========
Description was changed from ========== Enable Cardboard support on Daydream ready device BUG= ========== to ========== Enable Cardboard support on Daydream ready device BUG=671224 ==========
bshe@chromium.org changed reviewers: + mthiesse@chromium.org
Hi Micheal. Can you please take a look? Thanks.
The CQ bit was checked by bshe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2547973002/diff/20001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java (right): https://codereview.chromium.org/2547973002/diff/20001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java:269: if (mRequestedWebVR) nativeSetPresentResult(mNativeVrShellDelegate, true); Should return a new enum value like ENTER_VR_SUCCEEDED, and handle nativeSetPresentResult at the callsite.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bshe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2547973002/diff/20001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java (right): https://codereview.chromium.org/2547973002/diff/20001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java:269: if (mRequestedWebVR) nativeSetPresentResult(mNativeVrShellDelegate, true); On 2016/12/05 16:53:00, mthiesse wrote: > Should return a new enum value like ENTER_VR_SUCCEEDED, and handle > nativeSetPresentResult at the callsite. Done. Also changed the interface of presentRequested since inWebVR is always true.
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
The CQ bit was checked by bshe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bshe@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mthiesse@chromium.org Link to the patchset: https://codereview.chromium.org/2547973002/#ps60001 (title: "Add default")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480973778329780,
"parent_rev": "a55b66213152ae3bbaa2ffd0c319746d7a5603b9", "commit_rev":
"4950e1bf93bc58e81e0c8594e3b05754123cebf0"}
Message was sent while issue was closed.
Description was changed from ========== Enable Cardboard support on Daydream ready device BUG=671224 ========== to ========== Enable Cardboard support on Daydream ready device BUG=671224 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Enable Cardboard support on Daydream ready device BUG=671224 ========== to ========== Enable Cardboard support on Daydream ready device BUG=671224 Committed: https://crrev.com/f5e72ebfb73d97c2d7175d2fb578c48006b66c22 Cr-Commit-Position: refs/heads/master@{#436420} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/f5e72ebfb73d97c2d7175d2fb578c48006b66c22 Cr-Commit-Position: refs/heads/master@{#436420} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
