Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2547953002: Only generate summaries in tests when necessary (Closed)

Created:
4 years ago by Brian Wilkerson
Modified:
4 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -12 lines) Patch
M pkg/analysis_server/test/mock_sdk.dart View 3 chunks +19 lines, -7 lines 0 comments Download
M pkg/analyzer/test/src/context/mock_sdk.dart View 3 chunks +11 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/summary/pub_summary_test.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years ago (2016-12-02 19:52:26 UTC) #2
scheglov
LGTM
4 years ago (2016-12-02 20:00:40 UTC) #3
Brian Wilkerson
4 years ago (2016-12-02 20:01:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c75c14db545033c0ef01bae1a62801c5aa8d0ab1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698