Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2547943003: [ios] Adds reading_list and first_run resources (Closed)

Created:
4 years ago by sczs1
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Adds reading_list and first_run resources BUG=666732 Committed: https://crrev.com/de7089db5183c727efd8b615c02badf6ee41978c Cr-Commit-Position: refs/heads/master@{#436152}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -0 lines) Patch
A ios/chrome/browser/ui/first_run/BUILD.gn View 1 chunk +23 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/first_run/resources/FirstRun.xcassets/checkbox.imageset/Contents.json View 1 chunk +33 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/first_run/resources/FirstRun.xcassets/checkbox.imageset/checkbox.png View Binary file 0 comments Download
A ios/chrome/browser/ui/first_run/resources/FirstRun.xcassets/checkbox.imageset/checkbox@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/first_run/resources/FirstRun.xcassets/checkbox.imageset/checkbox@2x~ipad.png View Binary file 0 comments Download
A ios/chrome/browser/ui/first_run/resources/FirstRun.xcassets/checkbox.imageset/checkbox@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/first_run/resources/FirstRun.xcassets/checkbox.imageset/checkbox~ipad.png View Binary file 0 comments Download
A ios/chrome/browser/ui/first_run/resources/FirstRun.xcassets/checkbox_checked.imageset/Contents.json View 1 chunk +33 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/first_run/resources/FirstRun.xcassets/checkbox_checked.imageset/checkbox_checked.png View Binary file 0 comments Download
A ios/chrome/browser/ui/first_run/resources/FirstRun.xcassets/checkbox_checked.imageset/checkbox_checked@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/first_run/resources/FirstRun.xcassets/checkbox_checked.imageset/checkbox_checked@2x~ipad.png View Binary file 0 comments Download
A ios/chrome/browser/ui/first_run/resources/FirstRun.xcassets/checkbox_checked.imageset/checkbox_checked@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/first_run/resources/FirstRun.xcassets/checkbox_checked.imageset/checkbox_checked~ipad.png View Binary file 0 comments Download
A ios/chrome/browser/ui/reading_list/BUILD.gn View 1 chunk +23 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reading_list/resources/distillation_fail.png View Binary file 0 comments Download
A ios/chrome/browser/ui/reading_list/resources/distillation_fail@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/reading_list/resources/distillation_fail@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/reading_list/resources/distillation_success.png View Binary file 0 comments Download
A ios/chrome/browser/ui/reading_list/resources/distillation_success@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/reading_list/resources/distillation_success@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/reading_list/resources/reading_list_icon.png View Binary file 0 comments Download
A ios/chrome/browser/ui/reading_list/resources/reading_list_icon@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/reading_list/resources/reading_list_icon@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/reading_list/resources/share_icon.png View Binary file 0 comments Download
A ios/chrome/browser/ui/reading_list/resources/share_icon@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/reading_list/resources/share_icon@3x.png View Binary file 0 comments Download

Messages

Total messages: 9 (4 generated)
sczs1
PTAL
4 years ago (2016-12-02 21:00:58 UTC) #2
rohitrao (ping after 24h)
lgtm
4 years ago (2016-12-03 01:46:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2547943003/1
4 years ago (2016-12-03 01:46:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-03 02:58:25 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-03 03:00:37 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de7089db5183c727efd8b615c02badf6ee41978c
Cr-Commit-Position: refs/heads/master@{#436152}

Powered by Google App Engine
This is Rietveld 408576698