|
|
Chromium Code Reviews
DescriptionFix mac_views_browser compile after r435575 (extension_uninstall_dialog_view_browsertest.cc)
go/macviewsbuilder broke after r435575. It removed a flag that
extension_uninstall_dialog_view_browsertest.cc was using.
But extension_uninstall_dialog_view_browsertest.cc is only built on
mac_views_browser builds, which doesn't need flags in the first place
(it's a compile/build flag).
One of the tests does sadly fail (see http://crbug.com/671098), but
that's because it depends on things that should be gone by the time
mac_views_browser is a thing.
BUG=425229, 671098
Committed: https://crrev.com/9a6b54bf9e57746988176460c1bf636a26be7a10
Cr-Commit-Position: refs/heads/master@{#436240}
Patch Set 1 #Patch Set 2 : fix compile. test fails though #Patch Set 3 : A fix for the test, but I no likee #Patch Set 4 : Close.. but breaks sheet dialog resize #Patch Set 5 : Just fix compile #Patch Set 6 : Simpler #Messages
Total messages: 22 (17 generated)
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix mac_views_browser compile after r435575 BUG= ========== to ========== Fix mac_views_browser compile after r435575 (extension_uninstall_dialog_view_browsertest.cc) go/macviewsbuilder broke after r435575. It removed a flag that extension_uninstall_dialog_view_browsertest.cc was using. But extension_uninstall_dialog_view_browsertest.cc is only built on mac_views_browser builds, which doesn't need flags in the first place (it's a compile/build flag). One of the tests does sadly fail (see http://crbug.com/671098), but that's because depends on things that should be gone by the time mac_views_browser is a thing. BUG=425229, 671098 ==========
tapted@chromium.org changed reviewers: + benwells@chromium.org
Description was changed from ========== Fix mac_views_browser compile after r435575 (extension_uninstall_dialog_view_browsertest.cc) go/macviewsbuilder broke after r435575. It removed a flag that extension_uninstall_dialog_view_browsertest.cc was using. But extension_uninstall_dialog_view_browsertest.cc is only built on mac_views_browser builds, which doesn't need flags in the first place (it's a compile/build flag). One of the tests does sadly fail (see http://crbug.com/671098), but that's because depends on things that should be gone by the time mac_views_browser is a thing. BUG=425229, 671098 ========== to ========== Fix mac_views_browser compile after r435575 (extension_uninstall_dialog_view_browsertest.cc) go/macviewsbuilder broke after r435575. It removed a flag that extension_uninstall_dialog_view_browsertest.cc was using. But extension_uninstall_dialog_view_browsertest.cc is only built on mac_views_browser builds, which doesn't need flags in the first place (it's a compile/build flag). One of the tests does sadly fail (see http://crbug.com/671098), but that's because it depends on things that should be gone by the time mac_views_browser is a thing. BUG=425229, 671098 ==========
Hi ben, please take a look
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tapted@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1480923363583610,
"parent_rev": "08f52bfc0443c38a0b5c715ddf74811b5bfb6733", "commit_rev":
"8a409e9d5724f6598d7e2d96ceccbd68b88e5bbe"}
Message was sent while issue was closed.
Description was changed from ========== Fix mac_views_browser compile after r435575 (extension_uninstall_dialog_view_browsertest.cc) go/macviewsbuilder broke after r435575. It removed a flag that extension_uninstall_dialog_view_browsertest.cc was using. But extension_uninstall_dialog_view_browsertest.cc is only built on mac_views_browser builds, which doesn't need flags in the first place (it's a compile/build flag). One of the tests does sadly fail (see http://crbug.com/671098), but that's because it depends on things that should be gone by the time mac_views_browser is a thing. BUG=425229, 671098 ========== to ========== Fix mac_views_browser compile after r435575 (extension_uninstall_dialog_view_browsertest.cc) go/macviewsbuilder broke after r435575. It removed a flag that extension_uninstall_dialog_view_browsertest.cc was using. But extension_uninstall_dialog_view_browsertest.cc is only built on mac_views_browser builds, which doesn't need flags in the first place (it's a compile/build flag). One of the tests does sadly fail (see http://crbug.com/671098), but that's because it depends on things that should be gone by the time mac_views_browser is a thing. BUG=425229, 671098 ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Fix mac_views_browser compile after r435575 (extension_uninstall_dialog_view_browsertest.cc) go/macviewsbuilder broke after r435575. It removed a flag that extension_uninstall_dialog_view_browsertest.cc was using. But extension_uninstall_dialog_view_browsertest.cc is only built on mac_views_browser builds, which doesn't need flags in the first place (it's a compile/build flag). One of the tests does sadly fail (see http://crbug.com/671098), but that's because it depends on things that should be gone by the time mac_views_browser is a thing. BUG=425229, 671098 ========== to ========== Fix mac_views_browser compile after r435575 (extension_uninstall_dialog_view_browsertest.cc) go/macviewsbuilder broke after r435575. It removed a flag that extension_uninstall_dialog_view_browsertest.cc was using. But extension_uninstall_dialog_view_browsertest.cc is only built on mac_views_browser builds, which doesn't need flags in the first place (it's a compile/build flag). One of the tests does sadly fail (see http://crbug.com/671098), but that's because it depends on things that should be gone by the time mac_views_browser is a thing. BUG=425229, 671098 Committed: https://crrev.com/9a6b54bf9e57746988176460c1bf636a26be7a10 Cr-Commit-Position: refs/heads/master@{#436240} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/9a6b54bf9e57746988176460c1bf636a26be7a10 Cr-Commit-Position: refs/heads/master@{#436240} |
