Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2547923005: Fix mac_views_browser compile after r435575 (extension_uninstall_dialog_view_browsertest.cc) (Closed)

Created:
4 years ago by tapted
Modified:
4 years ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix mac_views_browser compile after r435575 (extension_uninstall_dialog_view_browsertest.cc) go/macviewsbuilder broke after r435575. It removed a flag that extension_uninstall_dialog_view_browsertest.cc was using. But extension_uninstall_dialog_view_browsertest.cc is only built on mac_views_browser builds, which doesn't need flags in the first place (it's a compile/build flag). One of the tests does sadly fail (see http://crbug.com/671098), but that's because it depends on things that should be gone by the time mac_views_browser is a thing. BUG=425229, 671098 Committed: https://crrev.com/9a6b54bf9e57746988176460c1bf636a26be7a10 Cr-Commit-Position: refs/heads/master@{#436240}

Patch Set 1 #

Patch Set 2 : fix compile. test fails though #

Patch Set 3 : A fix for the test, but I no likee #

Patch Set 4 : Close.. but breaks sheet dialog resize #

Patch Set 5 : Just fix compile #

Patch Set 6 : Simpler #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -22 lines) Patch
M chrome/browser/ui/views/extensions/extension_uninstall_dialog_view_browsertest.cc View 1 2 3 4 5 3 chunks +4 lines, -22 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
tapted
Hi ben, please take a look
4 years ago (2016-12-05 06:20:23 UTC) #12
benwells
lgtm
4 years ago (2016-12-05 06:30:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2547923005/100001
4 years ago (2016-12-05 07:36:15 UTC) #17
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years ago (2016-12-05 07:40:29 UTC) #20
commit-bot: I haz the power
4 years ago (2016-12-05 07:42:38 UTC) #22
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/9a6b54bf9e57746988176460c1bf636a26be7a10
Cr-Commit-Position: refs/heads/master@{#436240}

Powered by Google App Engine
This is Rietveld 408576698