Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 2547923003: Prevent new events from being sent to WebVR pages that are being closed. (Closed)

Created:
4 years ago by bajones
Modified:
4 years ago
Reviewers:
klausw, mthiesse
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent new events from being sent to WebVR pages that are being closed. BUG=670802 Committed: https://crrev.com/b771fd8575223a45d6493dca6267d2198a0db499 Cr-Commit-Position: refs/heads/master@{#436013}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M device/vr/vr_device.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
bajones
PTAL The crash in https://bugs.chromium.org/p/chromium/issues/detail?id=670802 is pretty tough to repro, but given the crash stack ...
4 years ago (2016-12-02 19:10:49 UTC) #2
klausw
LGTM
4 years ago (2016-12-02 19:30:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2547923003/1
4 years ago (2016-12-02 19:40:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 21:08:46 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-02 21:11:12 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b771fd8575223a45d6493dca6267d2198a0db499
Cr-Commit-Position: refs/heads/master@{#436013}

Powered by Google App Engine
This is Rietveld 408576698