Create a representation for OpenType variation settings

Create a representation for OpenType variation settings

Combine this with FontFeatureSettings as it is a very similar data
structure. The intention was to avoid duplication of the
FontFeatureSettings code and files.

No tests, no functional change.

BUG=670754
R=eae,kojii

Committed: https://crrev.com/7eac4cca7f82e500ef545bf9212b34d22289bc66
Cr-Commit-Position: refs/heads/master@{#436924}

[drott, 2016-12-02 17:43:39]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 17:44:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 19:44:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 19:44:03]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[drott, 2016-12-02 20:25:25]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 20:26:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 22:23:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 22:23:22]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[eae, 2016-12-03 09:08:29]

LGTM

Going forward we might want to consider a lighter-weight data structure but this
is fine for now.

[drott, 2016-12-05 12:05:48]

> Going forward we might want to consider a lighter-weight data structure but
this is fine for now.

I've been thinking about this for a while, and I think we do at least need to
store the tags and values. We could perhaps compact often used tags somehow, but
more generally, I think we can move from AtomicString to uint32_t for the tag
value. Is that what you had in mind, or would you have other suggestions on top
of that? Thanks.

[drott, 2016-12-05 13:00:34]

Add implementatino file to try fix windows linkage

[drott, 2016-12-05 13:00:35]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 13:00:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 13:00:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 13:00:47]

Dry run: CLs for remote refs other than refs/pending/heads/master must contain
NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them

[drott, 2016-12-05 13:20:31]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 13:20:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 13:20:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 13:20:57]

Dry run: CLs for remote refs other than refs/pending/heads/master must contain
NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them

[drott, 2016-12-05 13:37:25]

Change upstream branch

[drott, 2016-12-05 13:37:26]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 13:37:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eae, 2016-12-05 13:44:52]

On 2016/12/05 12:05:48, drott wrote:
> > Going forward we might want to consider a lighter-weight data structure but
> this is fine for now.
> 
> I've been thinking about this for a while, and I think we do at least need to
> store the tags and values. We could perhaps compact often used tags somehow,
but
> more generally, I think we can move from AtomicString to uint32_t for the tag
> value. Is that what you had in mind, or would you have other suggestions on
top
> of that? Thanks.

That sounds great and is along what I had in mind. Thanks!

(still LGTM)

[commit-bot: I haz the power, 2016-12-05 15:07:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 15:07:12]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[drott, 2016-12-07 10:09:43]

Windows linkage fixed by removing additional export declspecs

[drott, 2016-12-07 10:09:57]

The CQ bit was checked by drott@chromium.org

[drott, 2016-12-07 10:09:57]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2547923002/#ps60001
(title: "Windows linkage fixed by removing additional export declspecs")

[commit-bot: I haz the power, 2016-12-07 10:10:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 12:13:26]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481105397276700,
"parent_rev": "9e66022db375dc6c1939eaa7735173ee8610a720", "commit_rev":
"e94c72e0d3ed018a89c64212096a0855b7ed35a5"}

[commit-bot: I haz the power, 2016-12-07 12:13:52]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-07 12:16:16]

Description was changed from

==========
Create a representation for OpenType variation settings

Combine this with FontFeatureSettings as it is a very similar data
structure. The intention was to avoid duplication of the
FontFeatureSettings code and files.

No tests, no functional change.

BUG=670754
R=eae,kojii
==========

to

==========
Create a representation for OpenType variation settings

Combine this with FontFeatureSettings as it is a very similar data
structure. The intention was to avoid duplication of the
FontFeatureSettings code and files.

No tests, no functional change.

BUG=670754
R=eae,kojii

Committed: https://crrev.com/7eac4cca7f82e500ef545bf9212b34d22289bc66
Cr-Commit-Position: refs/heads/master@{#436924}
==========

[commit-bot: I haz the power, 2016-12-07 12:16:18]

Patchset 4 (id:??) landed as
https://crrev.com/7eac4cca7f82e500ef545bf9212b34d22289bc66
Cr-Commit-Position: refs/heads/master@{#436924}