Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2547863002: Move base32 into base so that it can be used within base.

Created:
4 years ago by grt (UTC plus 2)
Modified:
3 years, 8 months ago
CC:
blundell+watchlist_chromium.org, certificate-transparency-chrome_googlegroups.com, chromium-reviews, droger+watchlist_chromium.org, grt+watch_chromium.org, martijn+crwatch_martijnc.be, pennymac+watch_chromium.org, rsleevi+watch_chromium.org, sdefresne+watchlist_chromium.org, vmpstr+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move base32 into base so that it can be used within base. BUG=none R=gab@chromium.org,thakis@chromium.org TBR=eranm@chromium.org,jochen@chromium.org

Patch Set 1 #

Patch Set 2 : sync to position 437832 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -225 lines) Patch
M base/BUILD.gn View 1 2 chunks +3 lines, -0 lines 0 comments Download
M base/OWNERS View 1 chunk +4 lines, -0 lines 0 comments Download
A + base/base32.h View 2 chunks +8 lines, -7 lines 0 comments Download
A + base/base32.cc View 3 chunks +4 lines, -4 lines 0 comments Download
A + base/base32_unittest.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M chrome/installer/setup/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/setup/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/setup/user_hive_visitor.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/shell_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
D components/base32/BUILD.gn View 1 chunk +0 lines, -26 lines 0 comments Download
D components/base32/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D components/base32/base32.h View 1 chunk +0 lines, -34 lines 0 comments Download
D components/base32/base32.cc View 1 chunk +0 lines, -75 lines 0 comments Download
D components/base32/base32_unittest.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M components/certificate_transparency/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/certificate_transparency/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/certificate_transparency/log_dns_client.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (8 generated)
grt (UTC plus 2)
PTAL
4 years ago (2016-12-02 14:33:05 UTC) #5
Nico
On 2016/12/02 14:33:05, grt (UTC plus 1) wrote: > PTAL This doesn't add any uses ...
4 years ago (2016-12-02 14:35:35 UTC) #6
Eran Messeri
lgtm for components/certificate_transparency
4 years ago (2016-12-02 15:00:48 UTC) #7
grt (UTC plus 2)
On 2016/12/02 14:35:35, Nico wrote: > On 2016/12/02 14:33:05, grt (UTC plus 1) wrote: > ...
4 years ago (2016-12-02 15:09:56 UTC) #8
gab
rs-lgtm for deleting components/base32 and for chrome/installer side-effects. Leaving it up to Nico whether base/ ...
4 years ago (2016-12-02 19:04:10 UTC) #9
jochen (gone - plz use gerrit)
deferring to thakis (or any other base owner)
4 years ago (2016-12-05 15:33:53 UTC) #10
Nico
On 2016/12/02 15:09:56, grt (UTC plus 1) wrote: > On 2016/12/02 14:35:35, Nico wrote: > ...
3 years, 11 months ago (2017-01-10 18:00:18 UTC) #15
Eran Messeri
Wondering what the status of this CL is?
3 years, 8 months ago (2017-04-19 10:42:42 UTC) #16
grt (UTC plus 2)
3 years, 8 months ago (2017-04-19 13:52:13 UTC) #17
I'm still planning on getting back to
https://codereview.chromium.org/2545283002/ (which needs this) some day. I'm
happy to land it now if you have another need for it.

Powered by Google App Engine
This is Rietveld 408576698