Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderbuffer.cpp

Issue 2547813002: Remove WebGLObject maps from WebGLRenderingContextBase and WebGLContextGroup. (Closed)
Patch Set: Fixed WebGLContextObject::validate. Made WebGLExtension non-finalized. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webgl/WebGLRenderbuffer.cpp
diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderbuffer.cpp b/third_party/WebKit/Source/modules/webgl/WebGLRenderbuffer.cpp
index 4d13f95cd506c3caecc26a3530b5d7a4f29af4d5..34b4569e9d7f999b62e0ae2266a1e638500fa557 100644
--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderbuffer.cpp
+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderbuffer.cpp
@@ -34,11 +34,6 @@ WebGLRenderbuffer* WebGLRenderbuffer::create(WebGLRenderingContextBase* ctx) {
return new WebGLRenderbuffer(ctx);
}
-WebGLRenderbuffer::~WebGLRenderbuffer() {
- // See the comment in WebGLObject::detachAndDeleteObject().
- detachAndDeleteObject();
-}
-
WebGLRenderbuffer::WebGLRenderbuffer(WebGLRenderingContextBase* ctx)
: WebGLSharedPlatform3DObject(ctx),
m_internalFormat(GL_RGBA4),
@@ -50,6 +45,10 @@ WebGLRenderbuffer::WebGLRenderbuffer(WebGLRenderingContextBase* ctx)
setObject(rbo);
}
+WebGLRenderbuffer::~WebGLRenderbuffer() {
+ runDestructor();
+}
+
void WebGLRenderbuffer::deleteObjectImpl(gpu::gles2::GLES2Interface* gl) {
gl->DeleteRenderbuffers(1, &m_object);
m_object = 0;

Powered by Google App Engine
This is Rietveld 408576698