Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLContextObject.h

Issue 2547813002: Remove WebGLObject maps from WebGLRenderingContextBase and WebGLContextGroup. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webgl/WebGLContextObject.h
diff --git a/third_party/WebKit/Source/modules/webgl/WebGLContextObject.h b/third_party/WebKit/Source/modules/webgl/WebGLContextObject.h
index 1bcfc38322704d93d8c14a7acce6395897ecd6c0..a045a5958a116373ef76047d0ad1b728cead0e38 100644
--- a/third_party/WebKit/Source/modules/webgl/WebGLContextObject.h
+++ b/third_party/WebKit/Source/modules/webgl/WebGLContextObject.h
@@ -36,8 +36,6 @@ class WebGLRenderingContextBase;
// WebGLRenderingContextBase.
class WebGLContextObject : public WebGLObject {
public:
- ~WebGLContextObject() override;
-
WebGLRenderingContextBase* context() const { return m_context; }
bool validate(const WebGLContextGroup*,
@@ -45,8 +43,6 @@ class WebGLContextObject : public WebGLObject {
return context == m_context;
Zhenyao Mo 2016/12/02 18:58:39 Do we also want to check the numberOfContextLosses
Ken Russell (switch to Gerrit) 2016/12/02 22:13:38 Sorry, forgot to reply to your comment. Yes, thank
}
- void detachContext();
-
DECLARE_VIRTUAL_TRACE();
protected:
@@ -54,6 +50,8 @@ class WebGLContextObject : public WebGLObject {
bool hasGroupOrContext() const final { return m_context; }
+ uint32_t currentNumberOfContextLosses() const final;
+
gpu::gles2::GLES2Interface* getAGLInterface() const final;
private:

Powered by Google App Engine
This is Rietveld 408576698