Make Progress support an arbitrary number of columns.

Make Progress support an arbitrary number of columns.

Make isolateserver_load_test use this, so the amount of data sent is used in the
middle column.

Make many Progress members protected.

Remove QueueWithProgress.set_progress() and fix the constructors so it is not
necessary anymore.

R=vadimsh@chromium.org
BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=226590

[Marc-Antoine Ruel (Google), 2013-10-02 15:05:17]

Finally I coded the "arbitrary number of columns" I talked about in
https://codereview.chromium.org/25478010. I can merge both CL if you prefer.
Otherwise, this CL is dependent on it.

[Vadim Sh., 2013-10-02 18:41:41]

https://codereview.chromium.org/25478012/diff/1/tools/isolateserver_load_test.py
File tools/isolateserver_load_test.py (right):

https://codereview.chromium.org/25478012/diff/1/tools/isolateserver_load_test...
tools/isolateserver_load_test.py:133: progress.update_item('', col0=1,
col1=size)
I find 'colN' thing very confusing.

Alternative:

progress = Progress([('index', 0), ('size', 0), ('whatever', 0)])
...
progress.update('', size=1)
progress.update('stuff', index=1)
progress.update('', whatever=1)

Or even make '' default:
progress.update(size=1)
progress.update('Stuff', index=1)

wdyt?

[Marc-Antoine Ruel (Google), 2013-10-02 20:22:00]

On 2013/10/02 18:41:41, Vadim Sh. wrote:
>
https://codereview.chromium.org/25478012/diff/1/tools/isolateserver_load_test.py
> File tools/isolateserver_load_test.py (right):
> 
>
https://codereview.chromium.org/25478012/diff/1/tools/isolateserver_load_test...
> tools/isolateserver_load_test.py:133: progress.update_item('', col0=1,
> col1=size)
> I find 'colN' thing very confusing.
> 
> Alternative:
> 
> progress = Progress([('index', 0), ('size', 0), ('whatever', 0)])
> ...
> progress.update('', size=1)
> progress.update('stuff', index=1)
> progress.update('', whatever=1)
> 
> Or even make '' default:
> progress.update(size=1)
> progress.update('Stuff', index=1)
> 
> wdyt?

Done.

[Vadim Sh., 2013-10-02 21:09:12]

lgtm

[commit-bot: I haz the power, 2013-10-02 21:17:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/25478012/5001

[commit-bot: I haz the power, 2013-10-02 21:19:12]

Presubmit check for 25478012-5001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
/b/commit-queue/workdir/tools/swarm_client/googletest/tests/run_test_cases_smoke_test.py
failed
FFFFFF..FFF.FFFF
======================================================================
FAIL: test_confused_fail (__main__.RunTestCases)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/b/commit-queue/workdir/tools/swarm_client/googletest/tests/run_test_cases_smoke_test.py",
line 776, in test_confused_fail
    self._check_results(expected_out_re, out, err)
  File
"/b/commit-queue/workdir/tools/swarm_client/googletest/tests/run_test_cases_smoke_test.py",
line 148, in _check_results
    self.fail('%s\nerr:\n%s' % ('\n'.join(expected_out_re[index:]), err))
AssertionError: 
Failed\ tests\:
\ \ Foo\.Bar1
Summary\:
\ \ Success\:\ \ \ \ 0\ \ \ 0\.00\%\ \ \ \ 0\.00s
\ \ \ \ Flaky\:\ \ \ \ 0\ \ \ 0\.00\%\ \ \ \ 0\.00s
\ \ \ \ \ Fail\:\ \ \ \ 1\ 100\.00\%\  +\d+\.\d\ds
  \d+\.\d\ds Done running 1 tests with 3 executions. \d+\.\d\d test/s
err:
Traceback (most recent call last):
  File
"/b/commit-queue/workdir/tools/swarm_client/googletest/run_test_cases.py", line
1608, in <module>
    sys.exit(main(sys.argv[1:]))
  File
"/b/commit-queue/workdir/tools/swarm_client/googletest/run_test_cases.py", line
1601, in main
    options.verbose)
  File
"/b/commit-queue/workdir/tools/swarm_client/googletest/run_test_cases.py", line
1230, in run_test_cases
    duration = time.time() - pool.tasks.progress.start
AttributeError: 'Progress' object has no attribute 'start'


======================================================================
FAIL: test_confused_pass (__main__.RunTestCases)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/b/commit-queue/workdir/tools/swarm_client/googletest/tests/run_test_cases_smoke_test.py",
line 733, in test_confused_pass
    self._check_results(expected_out_re, out, err)
  File
"/b/commit-queue/workdir/tools/swarm_client/googletest/tests/run_test_cases_smoke_test.py",
line 148, in _check_results
    self.fail('%s\nerr:\n%s' % ('\n'.join(expected_out_re[index:]), err))
AssertionError: 
Failed\ tests\:
\ \ Foo\.Bar1
Summary\:
\ \ Success\:\ \ \ \ 0\ \ \ 0\.00\%\ \ \ \ 0\.00s
\ \ \ \ Flaky\:\ \ \ \ 0\ \ \ 0\.00\%\ \ \ \ 0\.00s
\ \ \ \ \ Fail\:\ \ \ \ 1\ 100\.00\%\  +\d+\.\d\ds
  \d+\.\d\ds Done running 1 tests with 3 executions. \d+\.\d\d test/s
err:
Traceback (most recent call last):
  File
"/b/commit-queue/workdir/tools/swarm_client/googletest/run_test_cases.py", line
1608, in <module>
    sys.exit(main(sys.argv[1:]))
  File
"/b/commit-queue/workdir/tools/swarm_client/googletest/run_test_cases.py", line
1601, in main
    options.verbose)
  File
"/b/commit-queue/workdir/tools/swarm_client/googletest/run_test_cases.py", line
1230, in run_test_cases
    duration = time.time() - pool.tasks.progress.start
AttributeError: 'Progress' object has no attribute 'start'


======================================================================
FAIL: test_crash_after_pass (__main__.RunTestCases)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/b/commit-queue/workdir/tools/swarm_client/googletest/tests/run_test_cases_smoke_test.py",
line 645, in test_crash_after_pass
    self.assertEqual(0, return_code)
AssertionError: 0 != 1

======================================================================
FAIL: test_flaky_stop_early (__main__.RunTestCases)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/b/commit-queue/workdir/tools/swarm_client/googletest/tests/run_test_cases_smoke_test.py",
line 522, in test_flaky_stop_early
    self.assertTrue('STOPPED EARLY' in out, out)
AssertionError: [0/9]   0.00s 
[ 1/10]   0.07s Foo.Bar1 (0.10s)
Note: Google Test filter = Foo.Bar1

[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[ RUN      ] Foo.Bar1
[  FAILED  ] Foo.Bar1 (100 ms)
[----------] 1 test from Foo
[----------] 1 test from Foo (100 ms total)


[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (30 ms total)
[  PASSED  ] 1 test.

  YOU HAVE 5 DISABLED TESTS


[ 2/11]   0.10s Foo.Bar5 (0.10s)
Note: Google Test filter = Foo.Bar5

[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[ RUN      ] Foo.Bar5
[  FAILED  ] Foo.Bar5 (100 ms)
[----------] 1 test from Foo
[----------] 1 test from Foo (100 ms total)


[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (30 ms total)
[  PASSED  ] 1 test.

  YOU HAVE 5 DISABLED TESTS


[ 3/12]   0.13s Foo.Bar4 (0.10s)
Note: Google Test filter = Foo.Bar4

[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[ RUN      ] Foo.Bar4
[  FAILED  ] Foo.Bar4 (100 ms)
[----------] 1 test from Foo
[----------] 1 test from Foo (100 ms total)


[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (30 ms total)
[  PASSED  ] 1 test.

  YOU HAVE 5 DISABLED TESTS


*****************************************************
*****************************************************
*****************************************************
WARNING: The remaining tests are going to be retried
serially. All tests should be isolated and be able to pass
regardless of what else is running.
If you see a test that can only pass serially, that test is
probably broken and should be fixed.
*****************************************************
*****************************************************
*****************************************************


======================================================================
FAIL: test_flaky_stop_early_xml (__main__.RunTestCases)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/b/commit-queue/workdir/tools/swarm_client/googletest/tests/run_test_cases_smoke_test.py",
line 561, in test_flaky_stop_early_xml
    self.assertEqual('', err)
AssertionError: '' != 'Traceback (most recent call last):\n  File
"/b/commit-queue/workdir/tools/swarm_client/googletest/run_test_cases.py", line
1608, in <module>\n    sys.exit(main(sys.argv[1:]))\n  File
"/b/commit-queue/workdir/tools/swarm_client/googletest/run_test_cases.py", line
1601, in main\n    options.verbose)\n  File
"/b/commit-queue/workdir/tools/swarm_client/googletest/run_test_cases.py", line
1230, in run_test_cases\n    duration = time.time() -
pool.tasks.progress.start\nAttributeError: \'Progress\' object has no attribute
\'start\'\n'

======================================================================
FAIL: test_gtest_filter (__main__.RunTestCases)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/b/commit-queue/workdir/tools/swarm_client/googletest/tests/run_test_cases_smoke_test.py",
line 797, in test_gtest_filter
    self.assertEqual(0, return_code, (out, err))
AssertionError: ('[0/2]   0.01s \n[1/2]   0.07s Foo.Bar/3 (0.10s)\n[2/2]   0.07s
Foo.Bar1 (0.10s) ', 'Traceback (most recent call last):\n  File
"/b/commit-queue/workdir/tools/swarm_client/googletest/run_test_cases.py", line
1608, in <module>\n    sys.exit(main(sys.argv[1:]))\n  File
"/b/commit-queue/workdir/tools/swarm_client/googletest/run_test_cases.py", line
1601, in main\n    options.verbose)\n  File
"/b/commit-queue/workdir/tools/swarm_client/googletest/run_test_cases.py", line
1230, in run_test_cases\n    duration = time.time() -
pool.tasks.progress.start\nAttributeError: \'Progress\' object has no attribute
\'start\'\n')

======================================================================
FAIL: test_missing (__main__.RunTestCases)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/b/commit-queue/workdir/tools/swarm_client/googletest/tests/run_test_cases_smoke_test.py",
line 620, in test_missing
    self._check_results(expected_out_re, out, err)
  File
"/b/commit-queue/workdir/tools/swarm_client/googletest/tests/run_test_cases_smoke_test.py",
line 148, in _check_results
    self.fail('%s\nerr:\n%s' % ('\n'.join(expected_out_re[index:]), err))
AssertionError: Flaky\ tests\:
\ \ Foo\.Bar1\ \(tried\ 2\ times\)
Failed\ tests\:
\ \ Foo\.Bar2
Summary\:
\ \ Success\:\ \ \ \ 1\ \ 33\.33\%\  +\d+\.\d\ds
\ \ \ \ Flaky\:\ \ \ \ 1\ \ 33\.33\%\  +\d+\.\d\ds
\ \ \ \ \ Fail\:\ \ \ \ 1\ \ 33\.33\%\  +\d+\.\d\ds
  \d+\.\d\ds Done running 3 tests with 6 executions. \d+\.\d\d test/s
err:
Traceback (most recent call last):
  File
"/b/commit-queue/workdir/tools/swarm_client/googletest/run_test_cases.py", line
1608, in <module>
    sys.exit(main(sys.argv[1:]))
  File
"/b/commit-queue/workdir/tools/swarm_client/googletest/run_test_cases.py", line
1601, in main
    options.verbose)
  File
"/b/commit-queue/workdir/tools/swarm_client/googletest/run_test_cases.py", line
1230, in run_test_cases
    duration = time.time() - pool.tasks.progress.start
AttributeError: 'Progress' object has no attribute 'start'


======================================================================
FAIL: test_simple_fail (__main__.RunTestCases)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/b/commit-queue/workdir/tools/swarm_client/googletest/tests/run_test_cases_smoke_test.py",
line 382, in test_simple_fail
    self._check_results(expected_out_re, out, err)
  File
"/b/commit-queue/workdir/tools/swarm_client/googletest/tests/run_test_cases_smoke_test.py",
line 148, in _check_results
    self.fail('%s\nerr:\n%s' % ('\n'.join(expected_out_re[index:]), err))
AssertionError: 
Failed\ tests\:
\ \ Baz\.Fail
Summary\:
\ \ Success\:\ \ …
(message too large)

[commit-bot: I haz the power, 2013-10-02 22:44:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/25478012/12001

[commit-bot: I haz the power, 2013-10-02 22:46:13]

Change committed as 226590