Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: tools/run_swarm_tests_on_swarm.py

Issue 25478010: Add ThreadPool.abort() to stop processing early. (Closed) Base URL: https://chromium.googlesource.com/a/chromium/tools/swarm_client@master
Patch Set: Add TODO Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/isolateserver_load_test.py ('k') | utils/threading_utils.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/run_swarm_tests_on_swarm.py
diff --git a/tools/run_swarm_tests_on_swarm.py b/tools/run_swarm_tests_on_swarm.py
index 6916cbea4cb89f0edd6eb979f097c9acd845eb27..4e3132fd84e0d46a9917dcb49b990bc78a2b68c2 100755
--- a/tools/run_swarm_tests_on_swarm.py
+++ b/tools/run_swarm_tests_on_swarm.py
@@ -75,11 +75,11 @@ class Runner(object):
step_name = '%s/%s (%3.2fs)' % (platform, test_name, duration)
if returncode:
self.progress.update_item(
- 'Failed to archive %s\n%s' % (step_name, stdout), index=True)
+ 'Failed to archive %s\n%s' % (step_name, stdout), index=1)
else:
hash_value = hashlib.sha1(open(isolated, 'rb').read()).hexdigest()
logging.info('%s: %s', step_name, hash_value)
- self.progress.update_item('Archived %s' % step_name, index=True)
+ self.progress.update_item('Archived %s' % step_name, index=1)
self.add_task(0, self.trigger, test, platform, hash_value)
finally:
try:
@@ -111,9 +111,9 @@ class Runner(object):
step_name = '%s/%s (%3.2fs)' % (platform, test_name, duration)
if returncode:
self.progress.update_item(
- 'Failed to trigger %s\n%s' % (step_name, stdout), index=True)
+ 'Failed to trigger %s\n%s' % (step_name, stdout), index=1)
else:
- self.progress.update_item('Triggered %s' % step_name, index=True)
+ self.progress.update_item('Triggered %s' % step_name, index=1)
self.add_task(0, self.get_result, test, platform)
return None
@@ -131,9 +131,9 @@ class Runner(object):
# Only print the output for failures, successes are unexciting.
if returncode:
self.progress.update_item(
- 'Failed %s:\n%s' % (step_name, stdout), index=True)
+ 'Failed %s:\n%s' % (step_name, stdout), index=1)
return (test_name, platform, stdout)
- self.progress.update_item('Passed %s' % step_name, index=True)
+ self.progress.update_item('Passed %s' % step_name, index=1)
return None
« no previous file with comments | « tools/isolateserver_load_test.py ('k') | utils/threading_utils.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698