sdk/lib/_internal/compiler/implementation/ssa/builder.dart - Issue 25478009: Handle compile-time constness for conditionals and type literal calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Issue 25478009: Handle compile-time constness for conditionals and type literal calls. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/resolution/members.dart ('K') | « sdk/lib/_internal/compiler/implementation/resolution/members.dart ('k') | tests/co19/co19-dart2js.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/builder.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/builder.dart b/sdk/lib/_internal/compiler/implementation/ssa/builder.dart

index 37585d821ce07f8d0520502623d728bbfa8b51b8..70713dad882d0a1001d0ca5d9df52d3f68575730 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/builder.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/builder.dart

@@ -3675,7 +3675,13 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {

Element element = elements[node];

if (element.isClass() || element.isTypedef()) {

// TODO(karlklose): add type representation

- stack.add(addConstant(node));

+ if (node.isCall) {

+ // The node itself is not a constant but we register the selector (the

+ // identifier that refers to the class/typedef) as a constant.

+ stack.add(addConstant(node.selector));

+ } else {

+ stack.add(addConstant(node));

+ }

} else if (element.isTypeVariable()) {

HInstruction value =

addTypeVariableReference(element.computeType(compiler));