Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 25478006: Nukes some dead TooltipManager code (Closed)

Created:
7 years, 2 months ago by sky
Modified:
7 years, 2 months ago
CC:
chromium-reviews, tfarina, ben+watch_chromium.org
Visibility:
Public.

Description

Nukes some dead TooltipManager code BUG=none TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226471

Patch Set 1 #

Patch Set 2 : Nuke field #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -177 lines) Patch
M ui/views/widget/aero_tooltip_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/tooltip_manager.h View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/views/widget/tooltip_manager_aura.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/widget/tooltip_manager_aura.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M ui/views/widget/tooltip_manager_win.h View 1 4 chunks +0 lines, -17 lines 0 comments Download
M ui/views/widget/tooltip_manager_win.cc View 6 chunks +64 lines, -143 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
sky
https://codereview.chromium.org/25478006/diff/3001/ui/views/widget/tooltip_manager_win.cc File ui/views/widget/tooltip_manager_win.cc (left): https://codereview.chromium.org/25478006/diff/3001/ui/views/widget/tooltip_manager_win.cc#oldcode150 ui/views/widget/tooltip_manager_win.cc:150: if (l_param->hwndFrom == tooltip_hwnd_ && keyboard_tooltip_hwnd_ == NULL) { ...
7 years, 2 months ago (2013-10-01 22:51:24 UTC) #1
Ben Goodger (Google)
lgtm
7 years, 2 months ago (2013-10-01 23:14:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/25478006/3001
7 years, 2 months ago (2013-10-01 23:20:45 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-02 00:15:57 UTC) #4
sky
7 years, 2 months ago (2013-10-02 16:01:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r226471 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698