Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2547793002: impl/memory: Use random int as auto generated task name in Task Queues. (Closed)

Created:
4 years ago by Vadim Sh.
Modified:
4 years ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

impl/memory: Use random int as auto generated task name in Task Queues. This matches reality better than a string or 500 random characters, and makes writing expectation-style tests simpler. R=iannucci@chromium.org BUG= Committed: https://github.com/luci/gae/commit/794153648435d6a4d6c77320da2ac10948e8800c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M impl/memory/taskqueue_data.go View 1 chunk +2 lines, -6 lines 0 comments Download
M impl/memory/taskqueue_test.go View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Vadim Sh.
4 years ago (2016-12-02 04:31:51 UTC) #1
iannucci
lgtm I'm really not sure what I was thinking at the time...
4 years ago (2016-12-02 19:31:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2547793002/1
4 years ago (2016-12-02 19:32:02 UTC) #4
commit-bot: I haz the power
4 years ago (2016-12-02 19:36:40 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/794153648435d6a4d6c77320da2ac10948e8800c

Powered by Google App Engine
This is Rietveld 408576698