Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2547773003: Reset WebMediaPlayerMS video layer on rotation change (Closed)

Created:
4 years ago by emircan
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Reset WebMediaPlayerMS video layer on rotation change Incoming video stream's rotation might change during the session, i.e. when the remote client changes between front/back camera. This CL adds checks to find when rotation changes and resets cc_blink::WebLayerImpl with the updated rotation information. BUG=669573, webrtc:6768 TEST=Added RotationChange unittest. Tested H264 AppRTC call between Nexus 5 and Linux while changing front/back camera. Review-Url: https://codereview.chromium.org/2536893002 Cr-Commit-Position: refs/heads/master@{#435113} (cherry picked from commit f79979ea2cff435564fe96a89b24533855f77213) NOTRY=true NOPRESUBMIT=true TBR=qiangchen@chromium.org,mcasas@chromium.org

Patch Set 1 : Reset WebMediaPlayerMS video layer on rotation change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -20 lines) Patch
M content/renderer/media/webmediaplayer_ms.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 2 chunks +27 lines, -15 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms_unittest.cc View 2 chunks +16 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2547773003/20001
4 years ago (2016-12-02 19:05:40 UTC) #4
commit-bot: I haz the power
4 years ago (2016-12-02 19:09:38 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698