Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2547743002: media: Remove suffix underscores from public member variables in AVDA (Closed)

Created:
4 years ago by watk
Modified:
4 years ago
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Remove suffix underscores from public member variables in AVDA This was not style guide compliant but now it mostly is.. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel BUG= Committed: https://crrev.com/353f713f3d559317b8901ebec53b9a93de978136 Cr-Commit-Position: refs/heads/master@{#435846}

Patch Set 1 #

Patch Set 2 : rebase so it patches #

Patch Set 3 : I missed two when rebasing #

Patch Set 4 : another one #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -60 lines) Patch
M media/gpu/android_video_decode_accelerator.cc View 1 2 14 chunks +28 lines, -30 lines 0 comments Download
M media/gpu/avda_codec_allocator.h View 1 1 chunk +15 lines, -18 lines 0 comments Download
M media/gpu/avda_codec_allocator.cc View 1 2 3 2 chunks +10 lines, -12 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 28 (19 generated)
watk
4 years ago (2016-12-02 00:31:33 UTC) #10
sandersd (OOO until July 31)
lgtm
4 years ago (2016-12-02 00:38:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2547743002/20001
4 years ago (2016-12-02 00:39:33 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/78171)
4 years ago (2016-12-02 00:56:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2547743002/40001
4 years ago (2016-12-02 01:05:35 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/174160)
4 years ago (2016-12-02 01:24:27 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2547743002/60001
4 years ago (2016-12-02 02:35:09 UTC) #24
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-02 03:38:02 UTC) #26
commit-bot: I haz the power
4 years ago (2016-12-02 03:40:46 UTC) #28
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/353f713f3d559317b8901ebec53b9a93de978136
Cr-Commit-Position: refs/heads/master@{#435846}

Powered by Google App Engine
This is Rietveld 408576698