Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2547733002:
Test expectations for virtual/mojo-loading and --site-per-process flag. (Closed)
|
Created:
4 years ago by Łukasz Anforowicz Modified:
4 years ago Reviewers:
alexmos CC:
chromium-reviews, blink-reviews, site-isolation-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionTest expectations for virtual/mojo-loading and --site-per-process flag.
BUG=670409
NOTRY=true
Committed: https://crrev.com/9747e02f384fecf9306345936122f77034db6181
Cr-Commit-Position: refs/heads/master@{#435803}
Patch Set 1 #
Total comments: 5
Patch Set 2 : Moving expectations to distinguish --site-per-process specific failures. #Messages
Total messages: 13 (5 generated)
lukasza@chromium.org changed reviewers: + alexmos@chromium.org
Alex, can you take a look please?
I'll shuffle around some exceptions to differentiate between once that 1) just weren't inherited from another expectations file and 2) ones that are specific to site-per-process. See my comments below. https://codereview.chromium.org/2547733002/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/FlagExpectations/site-per-process (right): https://codereview.chromium.org/2547733002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/FlagExpectations/site-per-process:152: crbug.com/670409 virtual/mojo-loading/http/tests/inspector/network/network-datareceived.html [ Timeout ] This test was added in SlowTests in r435577, but apparently these expectations are not inherited by site-per-process expectations file? :-( https://codereview.chromium.org/2547733002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/FlagExpectations/site-per-process:162: crbug.com/670409 virtual/mojo-loading/http/tests/perf/large-inlined-script.html [ Timeout ] This test was added in SlowTests in r435577, but apparently these expectations are not inherited by site-per-process expectations file? :-( https://codereview.chromium.org/2547733002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/FlagExpectations/site-per-process:164: crbug.com/670409 virtual/mojo-loading/http/tests/security/contentSecurityPolicy/require-sri-for/require-sri-for-script-preload-allowed.php [ Failure ] This test was added in RandomOrderExpectations in r435577, but apparently these expectations are not inherited by site-per-process expectations file? :-( https://codereview.chromium.org/2547733002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/FlagExpectations/site-per-process:166: crbug.com/670409 virtual/mojo-loading/http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html [ Timeout ] This test was added in RandomOrderExpectations in r435577, but apparently these expectations are not inherited by site-per-process expectations file? :-(
LGTM. It's sad that our normal site-per-process expectations for http/tests aren't inherited for virtual test suites, so I guess we do have to add all these. (This appears to be by design according to https://chromium.googlesource.com/chromium/src/+/master/docs/testing/layout_t...) I guess that we didn't run into this problem with other virtual test suites, because none of them currently run the http/tests subset.
The CQ bit was checked by lukasza@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from alexmos@chromium.org Link to the patchset: https://codereview.chromium.org/2547733002/#ps20001 (title: "Moving expectations to distinguish --site-per-process specific failures.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480640856714730,
"parent_rev": "879b6da6ae0c69687ef2f2375f296e0ab4dcc887", "commit_rev":
"152db2242390a2c0c73f85beeec9fab87c88aefe"}
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Thanks!
Message was sent while issue was closed.
Description was changed from ========== Test expectations for virtual/mojo-loading and --site-per-process flag. BUG=670409 NOTRY=true ========== to ========== Test expectations for virtual/mojo-loading and --site-per-process flag. BUG=670409 NOTRY=true Committed: https://crrev.com/9747e02f384fecf9306345936122f77034db6181 Cr-Commit-Position: refs/heads/master@{#435803} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/9747e02f384fecf9306345936122f77034db6181 Cr-Commit-Position: refs/heads/master@{#435803}
Message was sent while issue was closed.
https://codereview.chromium.org/2547733002/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/FlagExpectations/site-per-process (right): https://codereview.chromium.org/2547733002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/FlagExpectations/site-per-process:152: crbug.com/670409 virtual/mojo-loading/http/tests/inspector/network/network-datareceived.html [ Timeout ] On 2016/12/02 01:04:02, Łukasz Anforowicz wrote: > This test was added in SlowTests in r435577, but apparently these expectations > are not inherited by site-per-process expectations file? :-( I thought SlowTests were actually inherited for site-per-process expectations (and some other tests that were added to SlowTests in r435577 aren't showing up here), so perhaps these failures are actual timeouts and new/specific to the site-per-process and mojo-loading combination? Regardless, we can triage after we get the bots green. (It's annoying that they had to add duplicate expectations to SlowTests to start with, but I guess that's due to https://bugs.chromium.org/p/chromium/issues/detail?id=594216.) |
