Issue 254773002: Merge 261737 "Fixing a lifetime issue for Speech Recognition Bubble"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 254773002: Merge 261737 "Fixing a lifetime issue for Speech Recognition Bubble" (Closed)

Created:
6 years, 8 months ago by aarya

Modified:
6 years, 8 months ago

Reviewers:
Tommy Widenflycht

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/branches/1916/src/

Visibility:
Public.

Merge 261737 "Fixing a lifetime issue for Speech Recognition Bubble" > Fixing a lifetime issue for Speech Recognition Bubble > It seems that on a slow XP machine the view can be deleted before the > Impl. Fixed by a simple observer pattern. > > BUG=352851 > > Review URL: https://codereview.chromium.org/213153002 TBR=tommyw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266126

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -2 lines)			Patch
	M	chrome/browser/ui/views/speech_recognition_bubble_views.cc	View		5 chunks	+14 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r266126.