Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2547713003:
Returned MediaQuerySet should be const. (Closed)
DescriptionReturned MediaQuerySet should be const.
The MediaQuerySet is never modified outside the class. We don't have
any evidence that this fixes the mentioned issue though.
R=sigbjornf@opera.com
BUG=669757
Committed: https://crrev.com/88910ebeeacdcd83fa205afd44b49e664ea71838
Cr-Commit-Position: refs/heads/master@{#436031}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Fixed nit. #Patch Set 3 : Rebased #Messages
Total messages: 27 (17 generated)
Description was changed from ========== Returned MediaQuerySet should be const. The MediaQuerySet is never modified outside the class. We don't have any evidence that this fixes the mentioned issue though. R=sof@opera.com BUG=669757 ========== to ========== Returned MediaQuerySet should be const. The MediaQuerySet is never modified outside the class. We don't have any evidence that this fixes the mentioned issue though. R=sigbjornf@opera.com BUG=669757 ==========
rune@opera.com changed reviewers: + sigbjornf@opera.com - sof@opera.com
The CQ bit was checked by rune@opera.com to run a CQ dry run
ptal
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm, if no caller of the accessors wants to update the object. I don't it explains the problem on the associated bug. https://codereview.chromium.org/2547713003/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/css/CSSStyleSheet.h (right): https://codereview.chromium.org/2547713003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/css/CSSStyleSheet.h:102: const MediaQuerySet* mediaQueries() const { return m_mediaQueries.get(); } nit: get() is redundant.
https://codereview.chromium.org/2547713003/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/css/CSSStyleSheet.h (right): https://codereview.chromium.org/2547713003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/css/CSSStyleSheet.h:102: const MediaQuerySet* mediaQueries() const { return m_mediaQueries.get(); } On 2016/12/02 09:30:11, sof wrote: > nit: get() is redundant. Done.
The CQ bit was checked by rune@opera.com
The patchset sent to the CQ was uploaded after l-g-t-m from sigbjornf@opera.com Link to the patchset: https://codereview.chromium.org/2547713003/#ps20001 (title: "Fixed nit.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for third_party/WebKit/Source/core/css/CSSStyleSheet.h:
While running git apply --index -p1;
error: patch failed: third_party/WebKit/Source/core/css/CSSStyleSheet.h:99
error: third_party/WebKit/Source/core/css/CSSStyleSheet.h: patch does not
apply
Patch: third_party/WebKit/Source/core/css/CSSStyleSheet.h
Index: third_party/WebKit/Source/core/css/CSSStyleSheet.h
diff --git a/third_party/WebKit/Source/core/css/CSSStyleSheet.h
b/third_party/WebKit/Source/core/css/CSSStyleSheet.h
index
1ad6f458e2668f216503bd018bab13f3d7b49023..bf6c4a58c78cfc9ca743a5ca94914e67f41e735b
100644
--- a/third_party/WebKit/Source/core/css/CSSStyleSheet.h
+++ b/third_party/WebKit/Source/core/css/CSSStyleSheet.h
@@ -99,7 +99,7 @@ class CORE_EXPORT CSSStyleSheet final : public StyleSheet {
void clearOwnerRule() { m_ownerRule = nullptr; }
Document* ownerDocument() const;
- MediaQuerySet* mediaQueries() const { return m_mediaQueries.get(); }
+ const MediaQuerySet* mediaQueries() const { return m_mediaQueries; }
void setMediaQueries(MediaQuerySet*);
void setTitle(const String& title) { m_title = title; }
// Set by LinkStyle iff CORS-enabled fetch of stylesheet succeeded from this
The CQ bit was unchecked by rune@opera.com
The CQ bit was checked by rune@opera.com
The patchset sent to the CQ was uploaded after l-g-t-m from sigbjornf@opera.com Link to the patchset: https://codereview.chromium.org/2547713003/#ps40001 (title: "Rebased")
The CQ bit was unchecked by rune@opera.com
The CQ bit was checked by rune@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by rune@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480700370975180,
"parent_rev": "d70f5e3c7180502ef8f4cb9a8fb9d55bd9808d99", "commit_rev":
"6ba6f22a9bc5efab474a1d3eddfe45dc4d33f475"}
Message was sent while issue was closed.
Description was changed from ========== Returned MediaQuerySet should be const. The MediaQuerySet is never modified outside the class. We don't have any evidence that this fixes the mentioned issue though. R=sigbjornf@opera.com BUG=669757 ========== to ========== Returned MediaQuerySet should be const. The MediaQuerySet is never modified outside the class. We don't have any evidence that this fixes the mentioned issue though. R=sigbjornf@opera.com BUG=669757 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Returned MediaQuerySet should be const. The MediaQuerySet is never modified outside the class. We don't have any evidence that this fixes the mentioned issue though. R=sigbjornf@opera.com BUG=669757 ========== to ========== Returned MediaQuerySet should be const. The MediaQuerySet is never modified outside the class. We don't have any evidence that this fixes the mentioned issue though. R=sigbjornf@opera.com BUG=669757 Committed: https://crrev.com/88910ebeeacdcd83fa205afd44b49e664ea71838 Cr-Commit-Position: refs/heads/master@{#436031} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/88910ebeeacdcd83fa205afd44b49e664ea71838 Cr-Commit-Position: refs/heads/master@{#436031} |
