Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5244)

Unified Diff: appengine/findit/waterfall/test/swarming_util_test.py

Issue 2547713002: [Findit] Using ts_mon to track swarming/isolated server outages (Closed)
Patch Set: Fixing nit Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/waterfall/swarming_util.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/waterfall/test/swarming_util_test.py
diff --git a/appengine/findit/waterfall/test/swarming_util_test.py b/appengine/findit/waterfall/test/swarming_util_test.py
index d9283d381eb777ccc9ac8a03ddcff1f00883fb85..ea5c9c5bbe4a409f936106cd3bc222da3ad20701 100644
--- a/appengine/findit/waterfall/test/swarming_util_test.py
+++ b/appengine/findit/waterfall/test/swarming_util_test.py
@@ -644,7 +644,8 @@ class SwarmingUtilTest(wf_testcase.WaterfallTestCase):
@mock.patch.object(
RetryHttpClient, 'Get', side_effect=ConnectionClosedError())
def testSendRequestToServerConnectionClosedError(self, _):
- content, error = swarming_util._SendRequestToServer('url', HttpClient())
+ content, error = swarming_util._SendRequestToServer(
+ 'http://www.someurl.url', HttpClient())
self.assertIsNone(content)
self.assertEqual(
error['code'], swarming_util.URLFETCH_CONNECTION_CLOSED_ERROR)
@@ -652,14 +653,16 @@ class SwarmingUtilTest(wf_testcase.WaterfallTestCase):
@mock.patch.object(
RetryHttpClient, 'Get', side_effect=DeadlineExceededError())
def testSendRequestToServerDeadlineExceededError(self, _):
- content, error = swarming_util._SendRequestToServer('url', HttpClient())
+ content, error = swarming_util._SendRequestToServer(
+ 'http://www.someurl.com', HttpClient())
self.assertIsNone(content)
self.assertEqual(
error['code'], swarming_util.URLFETCH_DEADLINE_EXCEEDED_ERROR)
@mock.patch.object(RetryHttpClient, 'Get', side_effect=DownloadError())
def testSendRequestToServerDownloadError(self, _):
- content, error = swarming_util._SendRequestToServer('url', HttpClient())
+ content, error = swarming_util._SendRequestToServer(
+ 'http://www.someurl.com', HttpClient())
self.assertIsNone(content)
self.assertEqual(error['code'], swarming_util.URLFETCH_DOWNLOAD_ERROR)
@@ -677,7 +680,8 @@ class SwarmingUtilTest(wf_testcase.WaterfallTestCase):
}
self.UpdateUnitTestConfigSettings(
'swarming_settings', override_swarming_settings)
- content, error = swarming_util._SendRequestToServer('url', HttpClient())
+ content, error = swarming_util._SendRequestToServer(
+ 'http://www.someurl.com', HttpClient())
self.assertIsNone(content)
self.assertEqual(
error['code'], swarming_util.URLFETCH_CONNECTION_CLOSED_ERROR)
« no previous file with comments | « appengine/findit/waterfall/swarming_util.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698