appengine/findit/waterfall/monitoring.py - Issue 2547713002: [Findit] Using ts_mon to track swarming/isolated server outages

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: appengine/findit/waterfall/monitoring.py

Issue 2547713002: [Findit] Using ts_mon to track swarming/isolated server outages (Closed)

Patch Set: Addressing comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import gae_ts_mon	5 import gae_ts_mon

6	6

7 swarming_tasks = gae_ts_mon.CounterMetric(	7 swarming_tasks = gae_ts_mon.CounterMetric(

8 'findit/swarmingtasks', description='Swarming tasks triggered')	8 'findit/swarmingtasks', description='Swarming tasks triggered')

9	9

	10 http_errors = gae_ts_mon.CounterMetric(

	11 'findit/httperrors', description='Failed http requests to various servers')
	stgao 2016/12/01 23:27:51 nit: rename metric to "outgoinghttperrors" to be m nit: rename metric to "outgoinghttperrors" to be more clear? lijeffrey 2016/12/01 23:34:08 Done. Show quoted text On 2016/12/01 23:27:51, stgao (slow on Monday) wrote: > nit: rename metric to "outgoinghttperrors" to be more clear? Done.
	12

10 issues = gae_ts_mon.CounterMetric(	13 issues = gae_ts_mon.CounterMetric(

11 'findit/issues', description='Bugs updated with findings')	14 'findit/issues', description='Bugs updated with findings')

12	15

13 flakes = gae_ts_mon.CounterMetric(	16 flakes = gae_ts_mon.CounterMetric(

14 'findit/flakes', description='Flakes requested or analyzed')	17 'findit/flakes', description='Flakes requested or analyzed')

OLD	NEW

« no previous file with comments | « no previous file | appengine/findit/waterfall/swarming_util.py » ('j') | no next file with comments »