Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1493)

Unified Diff: chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_unittest.cc

Issue 2547703002: [Media Router] Handle multiple Presentation URLs when creating routes (Closed)
Patch Set: fix unittests Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_unittest.cc
diff --git a/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_unittest.cc b/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_unittest.cc
index d38be75120308d5d88fa3a823d5ca4b161493d4c..26bcbac11d2437a24561aed3cce61b65e7376789 100644
--- a/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_unittest.cc
+++ b/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_unittest.cc
@@ -1,6 +1,7 @@
// Copyright 2015 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include <vector>
#include "base/macros.h"
#include "chrome/browser/media/router/media_router_ui_service.h"
@@ -252,15 +253,16 @@ TEST_F(MediaRouterDialogControllerImplTest, NotifyActionController) {
EXPECT_CALL(*action_controller, OnDialogShown());
dialog_controller_->ShowMediaRouterDialogForPresentation(
- base::MakeUnique<CreatePresentationConnectionRequest>(
- RenderFrameHostId(1, 2), GURL("http://test.com"),
- GURL("http://example.com"),
- base::Bind(
- &MediaRouterDialogControllerImplTest::PresentationSuccessCallback,
- base::Unretained(this)),
- base::Bind(
- &MediaRouterDialogControllerImplTest::PresentationErrorCallback,
- base::Unretained(this))));
+ std::unique_ptr<CreatePresentationConnectionRequest>(
+ new CreatePresentationConnectionRequest(
+ RenderFrameHostId(1, 2), {GURL("http://test.com")},
mark a. foltz 2016/12/02 20:59:09 Can you pass multiple URLs here?
zhaobin 2016/12/02 22:50:57 Done.
+ GURL("http://example.com"),
+ base::Bind(&MediaRouterDialogControllerImplTest::
+ PresentationSuccessCallback,
+ base::Unretained(this)),
+ base::Bind(&MediaRouterDialogControllerImplTest::
+ PresentationErrorCallback,
+ base::Unretained(this)))));
// When |dialog_controller_| is destroyed with its dialog open,
// |action_controller| should be notified.

Powered by Google App Engine
This is Rietveld 408576698