Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2547693002: Use TaskScheduler instead of WorkerPool in sw_reporter_installer_win.cc. (Closed)

Created:
4 years ago by fdoray
Modified:
4 years ago
Reviewers:
Sorin Jianu
CC:
chromium-reviews, waffles
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use TaskScheduler instead of WorkerPool in sw_reporter_installer_win.cc. This CL replaces base::WorkerPool::PostTask() with base::PostTaskWithTraits() call. The following traits are used: Priority: BACKGROUND User won't notice if this task takes an arbitrarily long time to complete. Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). No File IO (default): The task does not perform synchronous IO operations. With Wait: The task waits on things other than synchronous file IO operations (e.g. WaitableEvent, ConditionVariable, join a thread, join a process, blocking system call that doesn't involve interactions with the file system). BUG=659191 Committed: https://crrev.com/e32266ffc0f2401f27c9ac05fb0a881f899c619a Cr-Commit-Position: refs/heads/master@{#435996}

Patch Set 1 #

Patch Set 2 : fix build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/browser/component_updater/sw_reporter_installer_win.cc View 1 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
fdoray
Please review this CL. In particular, make sure that the traits mentioned in the CL ...
4 years ago (2016-12-02 19:24:17 UTC) #10
Sorin Jianu
lgtm thank you!
4 years ago (2016-12-02 19:28:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2547693002/20001
4 years ago (2016-12-02 19:31:29 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-02 19:40:00 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-02 19:43:22 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e32266ffc0f2401f27c9ac05fb0a881f899c619a
Cr-Commit-Position: refs/heads/master@{#435996}

Powered by Google App Engine
This is Rietveld 408576698