Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2547683002: Analyze dev_compiler on the analyzer bot. (Closed)

Created:
4 years ago by Paul Berry
Modified:
4 years ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Analyze dev_compiler on the analyzer bot. This would have allowed me to catch the failure that forced 1d028eed8dfa00ac9d4ff685e61b01e6909dbeb4 to be reverted. R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/66bc76062109da64286cf7cf185783cd062a6b10

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M pkg/pkg.status View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years ago (2016-12-01 21:44:15 UTC) #2
Jennifer Messerly
lgtm
4 years ago (2016-12-01 21:46:19 UTC) #3
Paul Berry
4 years ago (2016-12-01 21:51:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
66bc76062109da64286cf7cf185783cd062a6b10 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698