Issue 2547653003: Page Info (Views): Change "Details" link (sec. panel) to "Learn more" (help center).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2547653003: Page Info (Views): Change "Details" link (sec. panel) to "Learn more" (help center). (Closed)

Created:
4 years ago by lgarron

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

Page Info (Views): Change "Details" link (sec. panel) to "Learn more" (help center). Since "Learn more" should show up unconditionally, this CL also removes the include_details_label_link calculation/parameter. BUG=646465 Review-Url: https://codereview.chromium.org/2506473002 Cr-Commit-Position: refs/heads/master@{#435083} (cherry picked from commit b822f27141186d301f3ee03805d29ecd9d00bbf7) Committed: https://chromium.googlesource.com/chromium/src/+/18643a2eb8c9685eeab7942fba55cd7a9f156a52

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -48 lines)			Patch
	M	chrome/browser/ui/views/website_settings/website_settings_popup_view.cc	View		8 chunks	+24 lines, -48 lines	0 comments	Download

Total messages: 2 (1 generated)

lgarron

4 years ago (2016-12-01 22:39:14 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
18643a2eb8c9685eeab7942fba55cd7a9f156a52.