chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc - Issue 2547633002: Desktop Capture API: Pass Audio Selection Information To Javascript

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc

Issue 2547633002: Desktop Capture API: Pass Audio Selection Information To Javascript (Closed)

Patch Set: Browser Test Case Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc ('k') | chrome/common/extensions/api/desktop_capture.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc

diff --git a/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc b/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc

index da43435a1b9c12bf15bbb42b3d41ac654ccb264f..a92d060ea896d58ed39fe88b2663c77776e0fcbc 100644

--- a/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc

+++ b/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc

@@ -240,7 +240,10 @@ void DesktopCaptureChooseDesktopMediaFunctionBase::OnPickerDialogResults(

extension()->name());

}

- SetResult(base::MakeUnique<base::StringValue>(result));

+ api::desktop_capture::ChooseDesktopMedia::Results::Options options;

+ options.can_request_audio_track = source.audio_share;

+ results_ = api::desktop_capture::ChooseDesktopMedia::Results::Create(result,

+ options);

SendResponse(true);

}