chrome/common/extensions/api/desktop_capture.json - Issue 2547633002: Desktop Capture API: Pass Audio Selection Information To Javascript

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/desktop_capture.json

Issue 2547633002: Desktop Capture API: Pass Audio Selection Information To Javascript (Closed)

Patch Set: Use Object Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc ('k') | chrome/common/extensions/docs/examples/api/desktopCapture/app.js » ('j') | chrome/common/extensions/docs/examples/api/desktopCapture/app.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/desktop_capture.json

diff --git a/chrome/common/extensions/api/desktop_capture.json b/chrome/common/extensions/api/desktop_capture.json

index 5b9ff002fcfd318f1e164990016d64ee846d1011..4195c7bc52f9013d91763c579ed233edad28abd7 100644

--- a/chrome/common/extensions/api/desktop_capture.json

+++ b/chrome/common/extensions/api/desktop_capture.json

@@ -40,6 +40,17 @@

"name": "streamId",

"type": "string",

"description": "An opaque string that can be passed to <code>getUserMedia()</code> API to generate media stream that corresponds to the source selected by the user. If user didn't select any source (i.e. canceled the prompt) then the callback is called with an empty <code>streamId</code>. The created <code>streamId</code> can be used only once and expires after a few seconds when it is not used."

+ },

+ {

+ "name": "options",

+ "type": "object",

+ "description": "Contains properties that describe the stream.",

+ "properties": {

+ "can_request_audio_track": {

Devlin 2016/12/13 16:05:44 Variables here should be JS-style, so canRequestAu

qiangchen 2016/12/13 19:04:32 Done.

+ "type": "boolean",

+ "description": "True if audio track is well generated. Otherwise false, and in this case, one should not ask for audio stream through getUserMedia call."

Devlin 2016/12/13 16:05:44 What does "well generated" mean? From the bug/desc

qiangchen 2016/12/13 19:04:32 Done. Changed to describing what happened in the f

+ }

}

]

}