Issue 254763008: Remove String::Visit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 254763008: Remove String::Visit (Closed)

Created:
6 years, 8 months ago by dcarney

Modified:
6 years, 7 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+159 lines, -274 lines)			Patch
M	src/objects.h	View	1	2 chunks	+31 lines, -44 lines	0 comments	Download
M	src/objects.cc	View	1	15 chunks	+76 lines, -90 lines	0 comments	Download
M	src/objects-inl.h	View	1	5 chunks	+32 lines, -111 lines	0 comments	Download
M	test/cctest/test-strings.cc	View		6 chunks	+20 lines, -29 lines	0 comments	Download

Total messages: 3 (0 generated)

dcarney

ptal - this is mostly a bunch of cleanup and gives a much nicer interface ...

6 years, 7 months ago (2014-04-29 08:01:10 UTC) #1

Yang

On 2014/04/29 08:01:10, dcarney wrote: > ptal - this is mostly a bunch of cleanup ...

6 years, 7 months ago (2014-04-29 08:43:04 UTC) #2

dcarney

6 years, 7 months ago (2014-04-29 13:09:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r21046 (presubmit successful).