chrome/browser/safe_browsing/safe_browsing_test.cc - Issue 254763005: Move some content url constants to /url.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_test.cc

Issue 254763005: Move some content url constants to /url. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update url/BUILD.gn and address some style nits. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/safe_browsing/safe_browsing_test.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_test.cc b/chrome/browser/safe_browsing/safe_browsing_test.cc

index 0f3b95e04810f8b0e8270b130956d37ea79c3056..9caa96a122cb6262f1dbfba3a87111166e9d6b95 100644

--- a/chrome/browser/safe_browsing/safe_browsing_test.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_test.cc

@@ -51,6 +51,7 @@

#include "net/url_request/url_fetcher_delegate.h"

#include "net/url_request/url_request_status.h"

#include "testing/gtest/include/gtest/gtest.h"

+#include "url/url_constants.h"

using content::BrowserThread;

@@ -91,8 +92,7 @@ bool ParsePhishingUrls(const std::string& data,

<< urls[i];

return false;

}

- phishing_url.url = std::string(content::kHttpScheme) +

- "://" + record_parts[0];

+ phishing_url.url = std::string(url::kHttpScheme) + "://" + record_parts[0];

phishing_url.list_name = record_parts[1];

if (record_parts[2] == "yes") {

phishing_url.is_phishing = true;