chrome/renderer/safe_browsing/phishing_classifier.cc - Issue 254763005: Move some content url constants to /url.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/safe_browsing/phishing_classifier.cc

Issue 254763005: Move some content url constants to /url. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and address some style nits. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/safe_browsing/phishing_classifier.cc

diff --git a/chrome/renderer/safe_browsing/phishing_classifier.cc b/chrome/renderer/safe_browsing/phishing_classifier.cc

index f48e6c138c74e444e79c58d8edb32809d2b6daa7..35665fb5dfb9b17cec9b3f939066e34b4dca1d2a 100644

--- a/chrome/renderer/safe_browsing/phishing_classifier.cc

+++ b/chrome/renderer/safe_browsing/phishing_classifier.cc

@@ -23,6 +23,7 @@

#include "chrome/renderer/safe_browsing/scorer.h"

#include "content/public/renderer/render_view.h"

#include "crypto/sha2.h"

+#include "net/base/url_constants.h"

#include "third_party/WebKit/public/platform/WebURL.h"

#include "third_party/WebKit/public/platform/WebURLRequest.h"

#include "third_party/WebKit/public/web/WebDataSource.h"

@@ -118,7 +119,7 @@ void PhishingClassifier::BeginFeatureExtraction() {

// Check whether the URL is one that we should classify.

// Currently, we only classify http: URLs that are GET requests.

GURL url(frame->document().url());

- if (!url.SchemeIs(content::kHttpScheme)) {

+ if (!url.SchemeIs(net::kHttpScheme)) {

RunFailureCallback();

return;

}