Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2547603002: Revert of Enable sRGB on iOS, make sRGB decode support optional (Closed)

Created:
4 years ago by Brian Osman
Modified:
4 years ago
Reviewers:
bsalomon
CC:
Chinmay, reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Enable sRGB on iOS, make sRGB decode support optional (patchset #11 id:200001 of https://codereview.chromium.org/2539993002/ ) Reason for revert: ANGLE tests are failing Original issue's description: > Two (related) changes here: > > 1) Our older iOS devices failed our sRGB tests, due to precision issues > with alpha. At this point, we only test on iPadMini 4, and that appears > not to have any problems. > > 2) iOS devices still don't have the sRGB texture decode extension. But, > some clients have no interest in mixing legacy/color-correct rendering, > and would like to use sRGB on these devices. This GrContextOptions flag > enables sRGB support in those cases. > > Adjust the test code to produce sRGB capable contexts on these devices, > but only for configs that have a color space. (See comment). > > BUG=skia:4148 > > Committed: https://skia.googlesource.com/skia/+/9db12d2341f3f8722c8b90b11dd4cce138a8a64e TBR=bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4148 Committed: https://skia.googlesource.com/skia/+/0a2782c98c45127a10d6392c539e7bce72dc5513

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -63 lines) Patch
M include/gpu/GrContextOptions.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 3 chunks +1 line, -5 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 4 chunks +7 lines, -17 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/SRGBMipMapTest.cpp View 2 chunks +2 lines, -13 lines 0 comments Download
M tools/flags/SkCommonFlagsConfig.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M tools/gpu/GrContextFactory.h View 1 chunk +4 lines, -5 lines 0 comments Download
M tools/gpu/GrContextFactory.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Brian Osman
Created Revert of Enable sRGB on iOS, make sRGB decode support optional
4 years ago (2016-12-01 18:41:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2547603002/1
4 years ago (2016-12-01 18:41:58 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-01 18:42:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0a2782c98c45127a10d6392c539e7bce72dc5513

Powered by Google App Engine
This is Rietveld 408576698