Landing Recent QUIC changes until Fri Nov 18 23:21:04 2016 +0000

Landing Recent QUIC changes until Fri Nov 18 23:21:04 2016 +0000

Remove the "New" prefix from various Ack-related structs/methods in QuicFramer now that there are only "new" acks.

Merge internal change: 139629781

https://codereview.chromium.org/2543953003/

Delete unused QuicData::owns_buffer method. No behavior change.

Merge internal change: 139611586

https://codereview.chromium.org/2544033002/

Split up quic_frames.{h,cc} into files for each frame type.

Merge internal change: 139607554

https://codereview.chromium.org/2545543003/

Fix MSAN failure due to reading from an uninitialized variable. No functional change (the variable is not used in uninitialized state).

Merge internal change: 139593422

https://codereview.chromium.org/2546583002/

Move PacketTimeVector typedef to quic_types.h. No behavior change.

Merge internal change: 139577765

https://codereview.chromium.org/2541233002/

Remove unnecessary (and incorrectly named) MaybeRemoveTransmittableFrames method. No behavior change.

MaybeRemoveRetransmittableFrames is only called from inside
RemoveRetransmittability, and it unconditionally removes frames, no
"maybe" about it :-)

Merge internal change: 139571201

https://codereview.chromium.org/2535753006/

Remove call to SetMaxPacketLength from QuicPacketCreator::OnSerializedPacket, as it will always be a no-op/early return. No behavior change.

Calling SetMaxPacketLength with max_packet_length_ as the argument hits
the early return here:

https://chromium.googlesource.com/chromium/src/+/bdbe864eb7ecdf545a6f6a63b635466f9c9465da/net/quic/core/quic_packet_creator.cc#74

Merge internal change: 139571059

https://codereview.chromium.org/2543833003/

Allow congestion controller state to be accessed by the debug visitors.

Merge internal change: 139513656

https://codereview.chromium.org/2540143003/

Implement pretty-printer for QuicConnectionStats

This function was declared in the header file, but didn't seem to be
defined anywhere?  I plan to use this function in an upcoming CL for
exercising various congestion-control algorithms.

Merge internal change: 139496268

https://codereview.chromium.org/2543813002/

Construct QuicFrames vectors directly in QuicFramerTest.

Merge internal change: 139492573

https://codereview.chromium.org/2538243002/

Delete unused index variable. No behavior change.

Merge internal change: 139492399

https://codereview.chromium.org/2543463005/

Make QuicClientBase::WaitForCryptoHandshakeComplete return false if the handshake fails. There's currently no verification that the handshake has succeeded when this method returns, resulting in buggy tests.

Merge internal change: 139469341

https://codereview.chromium.org/2542743003/

Write a regression test demonstrating that a QuicCryptoClientStream can receive and use a server config update with a valid certs and proofs.

Merge internal change: 139457701

https://codereview.chromium.org/2538923003/

Fix a bug in the handling of SCUP messages in QUIC clients.

Merge internal change: 139373466

https://codereview.chromium.org/2544493003/

Move QuicAckListenerInterface, QuicPendingRetransmission, and QuicTransmissionInfo out of quic_packets.{h,cc}. No behavior change.

Merge internal change: 139371729

https://codereview.chromium.org/2531163009/

Print out detailed_error_ in various LOG statements in QuicFramer.

Merge internal change: 139361927

https://codereview.chromium.org/2540873002/

Add ENDPOINT macro to QuicFramer (and include in existing LOG statement output).

Merge internal change: 139353951

https://codereview.chromium.org/2533303004/

Rename QuicInMemoryCache to QuicHttpResponseCache.

Merge internal change: 139246544

https://codereview.chromium.org/2532083005/

Rename quic_protocol to quic_packets. No behavior change.

Merge internal change: 139216821

https://codereview.chromium.org/2541673002/

Move remaining tests from quic_protocol_test.cc into appropriate locations.  These were missed during previous refactors.

Merge internal change: 139210181

https://codereview.chromium.org/2534253002/

Remove uses of gfe2::test::GenerateBody from QUIC code and use the string fill constructor instead.

Merge internal change: 139197459

https://codereview.chromium.org/2536033004/

QUIC - bugfix for forced head of line blocking experiment. Guarded by ENABLED --FLAGS_quic_bugfix_fhol_writev_fin_only_v2.

Fix bugs in FHOL:
o handle fin-only writev correctly.
o limit additional buffering to one HTTP/2 Data frame (~16KB).
o make headers stream flow control a large fixed size, rather than
using autotuning.

This is a redo of internal change 134345701, the only difference being
the headers stream flow control window size.

Merge internal change: 136086759

https://codereview.chromium.org/2535373002/

Split out QUIC frame definitions into quic_frames. No behavior change.

Merge internal change: 139196641

https://codereview.chromium.org/2537233002/

Remove unnecessary virtual keyword from QuicDefaultPacketWriter. No behavior change.

Merge internal change: 139192665

https://codereview.chromium.org/2537753004/

Add QUIC client connection options.  Only respected on the client side. No functional change.  Protected by ENABLED FLAGS_quic_client_connection_options.

Existing users of HasClientSentConnectionOptions are unchanged in order
to preserve existing behavior.  New users use
HasClientRequestedIndependentOption.

Merge internal change: 139159621

https://codereview.chromium.org/2537543005/

Move QuicVersionManager into standalone .h/.cc. No behavior change.

Merge internal change: 139117022

https://codereview.chromium.org/2535283002/

R=rch@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Committed: https://crrev.com/28270e8feac1cc094dff71351042f1d7fdb1d4e2
Cr-Commit-Position: refs/heads/master@{#435721}

[Victor Vasiliev, 2016-12-01 17:29:37]

Description was changed from

==========
Landing Recent QUIC changes until Fri Nov 18 23:21:04 2016 +0000

Remove the "New" prefix from various Ack-related structs/methods in QuicFramer
now that there are only "new" acks.

Merge internal change: 139629781

Delete unused QuicData::owns_buffer method. No behavior change.

Merge internal change: 139611586

Split up quic_frames.{h,cc} into files for each frame type.

Merge internal change: 139607554

Fix MSAN failure due to reading from an uninitialized variable. No functional
change (the variable is not used in uninitialized state).

Merge internal change: 139593422

Move PacketTimeVector typedef to quic_types.h. No behavior change.

Merge internal change: 139577765

Remove unnecessary (and incorrectly named) MaybeRemoveTransmittableFrames
method. No behavior change.

MaybeRemoveRetransmittableFrames is only called from inside
RemoveRetransmittability, and it unconditionally removes frames, no
"maybe" about it :-)

Merge internal change: 139571201

Remove call to SetMaxPacketLength from QuicPacketCreator::OnSerializedPacket, as
it will always be a no-op/early return. No behavior change.

Calling SetMaxPacketLength with max_packet_length_ as the argument hits
the early return here:

https://chromium.googlesource.com/chromium/src/+/bdbe864eb7ecdf545a6f6a63b635...

Merge internal change: 139571059

Allow congestion controller state to be accessed by the debug visitors.

Merge internal change: 139513656

Implement pretty-printer for QuicConnectionStats

This function was declared in the header file, but didn't seem to be
defined anywhere?  I plan to use this function in an upcoming CL for
exercising various congestion-control algorithms.

Merge internal change: 139496268

Construct QuicFrames vectors directly in QuicFramerTest.

Merge internal change: 139492573

Delete unused index variable. No behavior change.

Merge internal change: 139492399

Make QuicClientBase::WaitForCryptoHandshakeComplete return false if the
handshake fails. There's currently no verification that the handshake has
succeeded when this method returns, resulting in buggy tests.

Merge internal change: 139469341

Write a regression test demonstrating that a QuicCryptoClientStream can receive
and use a server config update with a valid certs and proofs.

Merge internal change: 139457701

Fix a bug in the handling of SCUP messages in QUIC clients.

Merge internal change: 139373466

Move QuicAckListenerInterface, QuicPendingRetransmission, and
QuicTransmissionInfo out of quic_packets.{h,cc}. No behavior change.

Merge internal change: 139371729

Print out detailed_error_ in various LOG statements in QuicFramer.

Merge internal change: 139361927

Add ENDPOINT macro to QuicFramer (and include in existing LOG statement output).

Merge internal change: 139353951

Rename QuicInMemoryCache to QuicHttpResponseCache.

Merge internal change: 139246544

Rename quic_protocol to quic_packets. No behavior change.

Merge internal change: 139216821

Move remaining tests from quic_protocol_test.cc into appropriate locations. 
These were missed during previous refactors.

Merge internal change: 139210181

Remove uses of gfe2::test::GenerateBody from QUIC code and use the string fill
constructor instead.

Merge internal change: 139197459

QUIC - bugfix for forced head of line blocking experiment. Guarded by ENABLED
--FLAGS_quic_bugfix_fhol_writev_fin_only_v2.

Fix bugs in FHOL:
   o handle fin-only writev correctly.
   o limit additional buffering to one HTTP/2 Data frame (~16KB).
   o make headers stream flow control a large fixed size, rather than
     using autotuning.

This is a redo of internal change 134345701, the only difference being
the headers stream flow control window size.

Merge internal change: 136086759

Split out QUIC frame definitions into quic_frames. No behavior change.

Merge internal change: 139196641

Remove unnecessary virtual keyword from QuicDefaultPacketWriter. No behavior
change.

Merge internal change: 139192665

Add QUIC client connection options.  Only respected on the client side. No
functional change.  Protected by ENABLED FLAGS_quic_client_connection_options.

Existing users of HasClientSentConnectionOptions are unchanged in order
to preserve existing behavior.  New users use
HasClientRequestedIndependentOption.

Merge internal change: 139159621

Move QuicVersionManager into standalone .h/.cc. No behavior change.

Merge internal change: 139117022

R=rch@chromium.org
BUG=
==========

to

==========
Landing Recent QUIC changes until Fri Nov 18 23:21:04 2016 +0000

Remove the "New" prefix from various Ack-related structs/methods in QuicFramer
now that there are only "new" acks.

Merge internal change: 139629781

Delete unused QuicData::owns_buffer method. No behavior change.

Merge internal change: 139611586

Split up quic_frames.{h,cc} into files for each frame type.

Merge internal change: 139607554

Fix MSAN failure due to reading from an uninitialized variable. No functional
change (the variable is not used in uninitialized state).

Merge internal change: 139593422

Move PacketTimeVector typedef to quic_types.h. No behavior change.

Merge internal change: 139577765

Remove unnecessary (and incorrectly named) MaybeRemoveTransmittableFrames
method. No behavior change.

MaybeRemoveRetransmittableFrames is only called from inside
RemoveRetransmittability, and it unconditionally removes frames, no
"maybe" about it :-)

Merge internal change: 139571201

Remove call to SetMaxPacketLength from QuicPacketCreator::OnSerializedPacket, as
it will always be a no-op/early return. No behavior change.

Calling SetMaxPacketLength with max_packet_length_ as the argument hits
the early return here:

https://chromium.googlesource.com/chromium/src/+/bdbe864eb7ecdf545a6f6a63b635...

Merge internal change: 139571059

Allow congestion controller state to be accessed by the debug visitors.

Merge internal change: 139513656

Implement pretty-printer for QuicConnectionStats

This function was declared in the header file, but didn't seem to be
defined anywhere?  I plan to use this function in an upcoming CL for
exercising various congestion-control algorithms.

Merge internal change: 139496268

Construct QuicFrames vectors directly in QuicFramerTest.

Merge internal change: 139492573

Delete unused index variable. No behavior change.

Merge internal change: 139492399

Make QuicClientBase::WaitForCryptoHandshakeComplete return false if the
handshake fails. There's currently no verification that the handshake has
succeeded when this method returns, resulting in buggy tests.

Merge internal change: 139469341

Write a regression test demonstrating that a QuicCryptoClientStream can receive
and use a server config update with a valid certs and proofs.

Merge internal change: 139457701

Fix a bug in the handling of SCUP messages in QUIC clients.

Merge internal change: 139373466

Move QuicAckListenerInterface, QuicPendingRetransmission, and
QuicTransmissionInfo out of quic_packets.{h,cc}. No behavior change.

Merge internal change: 139371729

Print out detailed_error_ in various LOG statements in QuicFramer.

Merge internal change: 139361927

Add ENDPOINT macro to QuicFramer (and include in existing LOG statement output).

Merge internal change: 139353951

Rename QuicInMemoryCache to QuicHttpResponseCache.

Merge internal change: 139246544

Rename quic_protocol to quic_packets. No behavior change.

Merge internal change: 139216821

Move remaining tests from quic_protocol_test.cc into appropriate locations. 
These were missed during previous refactors.

Merge internal change: 139210181

Remove uses of gfe2::test::GenerateBody from QUIC code and use the string fill
constructor instead.

Merge internal change: 139197459

QUIC - bugfix for forced head of line blocking experiment. Guarded by ENABLED
--FLAGS_quic_bugfix_fhol_writev_fin_only_v2.

Fix bugs in FHOL:
   o handle fin-only writev correctly.
   o limit additional buffering to one HTTP/2 Data frame (~16KB).
   o make headers stream flow control a large fixed size, rather than
     using autotuning.

This is a redo of internal change 134345701, the only difference being
the headers stream flow control window size.

Merge internal change: 136086759

Split out QUIC frame definitions into quic_frames. No behavior change.

Merge internal change: 139196641

Remove unnecessary virtual keyword from QuicDefaultPacketWriter. No behavior
change.

Merge internal change: 139192665

Add QUIC client connection options.  Only respected on the client side. No
functional change.  Protected by ENABLED FLAGS_quic_client_connection_options.

Existing users of HasClientSentConnectionOptions are unchanged in order
to preserve existing behavior.  New users use
HasClientRequestedIndependentOption.

Merge internal change: 139159621

Move QuicVersionManager into standalone .h/.cc. No behavior change.

Merge internal change: 139117022

R=rch@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[Victor Vasiliev, 2016-12-01 17:30:49]

The CQ bit was checked by vasilvv@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 17:31:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 17:54:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 17:54:22]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ryan Hamilton, 2016-12-01 18:03:02]

lgtm, but please update the CL description to include the chromium URLs for each
of the individual changes.

[Victor Vasiliev, 2016-12-01 18:24:29]

The CQ bit was checked by vasilvv@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 18:24:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 18:35:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 18:35:09]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Victor Vasiliev, 2016-12-01 19:03:34]

The CQ bit was checked by vasilvv@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 19:04:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 19:17:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 19:17:30]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Victor Vasiliev, 2016-12-01 19:35:18]

The CQ bit was checked by vasilvv@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 19:35:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Victor Vasiliev, 2016-12-01 19:52:33]

Description was changed from

==========
Landing Recent QUIC changes until Fri Nov 18 23:21:04 2016 +0000

Remove the "New" prefix from various Ack-related structs/methods in QuicFramer
now that there are only "new" acks.

Merge internal change: 139629781

Delete unused QuicData::owns_buffer method. No behavior change.

Merge internal change: 139611586

Split up quic_frames.{h,cc} into files for each frame type.

Merge internal change: 139607554

Fix MSAN failure due to reading from an uninitialized variable. No functional
change (the variable is not used in uninitialized state).

Merge internal change: 139593422

Move PacketTimeVector typedef to quic_types.h. No behavior change.

Merge internal change: 139577765

Remove unnecessary (and incorrectly named) MaybeRemoveTransmittableFrames
method. No behavior change.

MaybeRemoveRetransmittableFrames is only called from inside
RemoveRetransmittability, and it unconditionally removes frames, no
"maybe" about it :-)

Merge internal change: 139571201

Remove call to SetMaxPacketLength from QuicPacketCreator::OnSerializedPacket, as
it will always be a no-op/early return. No behavior change.

Calling SetMaxPacketLength with max_packet_length_ as the argument hits
the early return here:

https://chromium.googlesource.com/chromium/src/+/bdbe864eb7ecdf545a6f6a63b635...

Merge internal change: 139571059

Allow congestion controller state to be accessed by the debug visitors.

Merge internal change: 139513656

Implement pretty-printer for QuicConnectionStats

This function was declared in the header file, but didn't seem to be
defined anywhere?  I plan to use this function in an upcoming CL for
exercising various congestion-control algorithms.

Merge internal change: 139496268

Construct QuicFrames vectors directly in QuicFramerTest.

Merge internal change: 139492573

Delete unused index variable. No behavior change.

Merge internal change: 139492399

Make QuicClientBase::WaitForCryptoHandshakeComplete return false if the
handshake fails. There's currently no verification that the handshake has
succeeded when this method returns, resulting in buggy tests.

Merge internal change: 139469341

Write a regression test demonstrating that a QuicCryptoClientStream can receive
and use a server config update with a valid certs and proofs.

Merge internal change: 139457701

Fix a bug in the handling of SCUP messages in QUIC clients.

Merge internal change: 139373466

Move QuicAckListenerInterface, QuicPendingRetransmission, and
QuicTransmissionInfo out of quic_packets.{h,cc}. No behavior change.

Merge internal change: 139371729

Print out detailed_error_ in various LOG statements in QuicFramer.

Merge internal change: 139361927

Add ENDPOINT macro to QuicFramer (and include in existing LOG statement output).

Merge internal change: 139353951

Rename QuicInMemoryCache to QuicHttpResponseCache.

Merge internal change: 139246544

Rename quic_protocol to quic_packets. No behavior change.

Merge internal change: 139216821

Move remaining tests from quic_protocol_test.cc into appropriate locations. 
These were missed during previous refactors.

Merge internal change: 139210181

Remove uses of gfe2::test::GenerateBody from QUIC code and use the string fill
constructor instead.

Merge internal change: 139197459

QUIC - bugfix for forced head of line blocking experiment. Guarded by ENABLED
--FLAGS_quic_bugfix_fhol_writev_fin_only_v2.

Fix bugs in FHOL:
   o handle fin-only writev correctly.
   o limit additional buffering to one HTTP/2 Data frame (~16KB).
   o make headers stream flow control a large fixed size, rather than
     using autotuning.

This is a redo of internal change 134345701, the only difference being
the headers stream flow control window size.

Merge internal change: 136086759

Split out QUIC frame definitions into quic_frames. No behavior change.

Merge internal change: 139196641

Remove unnecessary virtual keyword from QuicDefaultPacketWriter. No behavior
change.

Merge internal change: 139192665

Add QUIC client connection options.  Only respected on the client side. No
functional change.  Protected by ENABLED FLAGS_quic_client_connection_options.

Existing users of HasClientSentConnectionOptions are unchanged in order
to preserve existing behavior.  New users use
HasClientRequestedIndependentOption.

Merge internal change: 139159621

Move QuicVersionManager into standalone .h/.cc. No behavior change.

Merge internal change: 139117022

R=rch@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Landing Recent QUIC changes until Fri Nov 18 23:21:04 2016 +0000

Remove the "New" prefix from various Ack-related structs/methods in QuicFramer
now that there are only "new" acks.

Merge internal change: 139629781

https://codereview.chromium.org/2543953003/

Delete unused QuicData::owns_buffer method. No behavior change.

Merge internal change: 139611586

https://codereview.chromium.org/2544033002/

Split up quic_frames.{h,cc} into files for each frame type.

Merge internal change: 139607554

https://codereview.chromium.org/2545543003/

Fix MSAN failure due to reading from an uninitialized variable. No functional
change (the variable is not used in uninitialized state).

Merge internal change: 139593422

https://codereview.chromium.org/2546583002/

Move PacketTimeVector typedef to quic_types.h. No behavior change.

Merge internal change: 139577765

https://codereview.chromium.org/2541233002/

Remove unnecessary (and incorrectly named) MaybeRemoveTransmittableFrames
method. No behavior change.

MaybeRemoveRetransmittableFrames is only called from inside
RemoveRetransmittability, and it unconditionally removes frames, no
"maybe" about it :-)

Merge internal change: 139571201

https://codereview.chromium.org/2535753006/

Remove call to SetMaxPacketLength from QuicPacketCreator::OnSerializedPacket, as
it will always be a no-op/early return. No behavior change.

Calling SetMaxPacketLength with max_packet_length_ as the argument hits
the early return here:

https://chromium.googlesource.com/chromium/src/+/bdbe864eb7ecdf545a6f6a63b635...

Merge internal change: 139571059

https://codereview.chromium.org/2543833003/

Allow congestion controller state to be accessed by the debug visitors.

Merge internal change: 139513656

https://codereview.chromium.org/2540143003/

Implement pretty-printer for QuicConnectionStats

This function was declared in the header file, but didn't seem to be
defined anywhere?  I plan to use this function in an upcoming CL for
exercising various congestion-control algorithms.

Merge internal change: 139496268

https://codereview.chromium.org/2543813002/

Construct QuicFrames vectors directly in QuicFramerTest.

Merge internal change: 139492573

https://codereview.chromium.org/2538243002/

Delete unused index variable. No behavior change.

Merge internal change: 139492399

https://codereview.chromium.org/2543463005/

Make QuicClientBase::WaitForCryptoHandshakeComplete return false if the
handshake fails. There's currently no verification that the handshake has
succeeded when this method returns, resulting in buggy tests.

Merge internal change: 139469341

https://codereview.chromium.org/2542743003/

Write a regression test demonstrating that a QuicCryptoClientStream can receive
and use a server config update with a valid certs and proofs.

Merge internal change: 139457701

https://codereview.chromium.org/2538923003/

Fix a bug in the handling of SCUP messages in QUIC clients.

Merge internal change: 139373466

https://codereview.chromium.org/2544493003/

Move QuicAckListenerInterface, QuicPendingRetransmission, and
QuicTransmissionInfo out of quic_packets.{h,cc}. No behavior change.

Merge internal change: 139371729

https://codereview.chromium.org/2531163009/

Print out detailed_error_ in various LOG statements in QuicFramer.

Merge internal change: 139361927

https://codereview.chromium.org/2540873002/

Add ENDPOINT macro to QuicFramer (and include in existing LOG statement output).

Merge internal change: 139353951

https://codereview.chromium.org/2533303004/

Rename QuicInMemoryCache to QuicHttpResponseCache.

Merge internal change: 139246544

https://codereview.chromium.org/2532083005/

Rename quic_protocol to quic_packets. No behavior change.

Merge internal change: 139216821

https://codereview.chromium.org/2541673002/

Move remaining tests from quic_protocol_test.cc into appropriate locations. 
These were missed during previous refactors.

Merge internal change: 139210181

https://codereview.chromium.org/2534253002/

Remove uses of gfe2::test::GenerateBody from QUIC code and use the string fill
constructor instead.

Merge internal change: 139197459

https://codereview.chromium.org/2536033004/

QUIC - bugfix for forced head of line blocking experiment. Guarded by ENABLED
--FLAGS_quic_bugfix_fhol_writev_fin_only_v2.

Fix bugs in FHOL:
o handle fin-only writev correctly.
o limit additional buffering to one HTTP/2 Data frame (~16KB).
o make headers stream flow control a large fixed size, rather than
using autotuning.

This is a redo of internal change 134345701, the only difference being
the headers stream flow control window size.

Merge internal change: 136086759

https://codereview.chromium.org/2535373002/

Split out QUIC frame definitions into quic_frames. No behavior change.

Merge internal change: 139196641

https://codereview.chromium.org/2537233002/

Remove unnecessary virtual keyword from QuicDefaultPacketWriter. No behavior
change.

Merge internal change: 139192665

https://codereview.chromium.org/2537753004/

Add QUIC client connection options.  Only respected on the client side. No
functional change.  Protected by ENABLED FLAGS_quic_client_connection_options.

Existing users of HasClientSentConnectionOptions are unchanged in order
to preserve existing behavior.  New users use
HasClientRequestedIndependentOption.

Merge internal change: 139159621

https://codereview.chromium.org/2537543005/

Move QuicVersionManager into standalone .h/.cc. No behavior change.

Merge internal change: 139117022

https://codereview.chromium.org/2535283002/

R=rch@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[Victor Vasiliev, 2016-12-01 20:19:48]

vasilvv@chromium.org changed reviewers:
+ mef@chromium.org

[Victor Vasiliev, 2016-12-01 20:20:15]

Adding mef@ for cronet and grpc_support.

[mef, 2016-12-01 20:27:38]

components/cronet and components/grpc_support lgtm

[Victor Vasiliev, 2016-12-01 21:22:23]

The CQ bit was unchecked by vasilvv@chromium.org

[Ryan Hamilton, 2016-12-01 21:22:43]

The CQ bit was unchecked by rch@chromium.org

[Victor Vasiliev, 2016-12-01 21:22:47]

The CQ bit was checked by vasilvv@chromium.org

[Victor Vasiliev, 2016-12-01 21:22:48]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2547583002/#ps80001
(title: "Remove explicit HTTP/2 enum usage")

[Ryan Hamilton, 2016-12-01 21:22:50]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2016-12-01 21:23:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 21:38:13]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480627370112860,
"parent_rev": "5565f44fea2612a46a3c3ef93e432675060a525d", "commit_rev":
"3576929d8977adf3cbf22317ab9074499b9c45ba"}

[commit-bot: I haz the power, 2016-12-01 21:38:38]

Description was changed from

==========
Landing Recent QUIC changes until Fri Nov 18 23:21:04 2016 +0000

Remove the "New" prefix from various Ack-related structs/methods in QuicFramer
now that there are only "new" acks.

Merge internal change: 139629781

https://codereview.chromium.org/2543953003/

Delete unused QuicData::owns_buffer method. No behavior change.

Merge internal change: 139611586

https://codereview.chromium.org/2544033002/

Split up quic_frames.{h,cc} into files for each frame type.

Merge internal change: 139607554

https://codereview.chromium.org/2545543003/

Fix MSAN failure due to reading from an uninitialized variable. No functional
change (the variable is not used in uninitialized state).

Merge internal change: 139593422

https://codereview.chromium.org/2546583002/

Move PacketTimeVector typedef to quic_types.h. No behavior change.

Merge internal change: 139577765

https://codereview.chromium.org/2541233002/

Remove unnecessary (and incorrectly named) MaybeRemoveTransmittableFrames
method. No behavior change.

MaybeRemoveRetransmittableFrames is only called from inside
RemoveRetransmittability, and it unconditionally removes frames, no
"maybe" about it :-)

Merge internal change: 139571201

https://codereview.chromium.org/2535753006/

Remove call to SetMaxPacketLength from QuicPacketCreator::OnSerializedPacket, as
it will always be a no-op/early return. No behavior change.

Calling SetMaxPacketLength with max_packet_length_ as the argument hits
the early return here:

https://chromium.googlesource.com/chromium/src/+/bdbe864eb7ecdf545a6f6a63b635...

Merge internal change: 139571059

https://codereview.chromium.org/2543833003/

Allow congestion controller state to be accessed by the debug visitors.

Merge internal change: 139513656

https://codereview.chromium.org/2540143003/

Implement pretty-printer for QuicConnectionStats

This function was declared in the header file, but didn't seem to be
defined anywhere?  I plan to use this function in an upcoming CL for
exercising various congestion-control algorithms.

Merge internal change: 139496268

https://codereview.chromium.org/2543813002/

Construct QuicFrames vectors directly in QuicFramerTest.

Merge internal change: 139492573

https://codereview.chromium.org/2538243002/

Delete unused index variable. No behavior change.

Merge internal change: 139492399

https://codereview.chromium.org/2543463005/

Make QuicClientBase::WaitForCryptoHandshakeComplete return false if the
handshake fails. There's currently no verification that the handshake has
succeeded when this method returns, resulting in buggy tests.

Merge internal change: 139469341

https://codereview.chromium.org/2542743003/

Write a regression test demonstrating that a QuicCryptoClientStream can receive
and use a server config update with a valid certs and proofs.

Merge internal change: 139457701

https://codereview.chromium.org/2538923003/

Fix a bug in the handling of SCUP messages in QUIC clients.

Merge internal change: 139373466

https://codereview.chromium.org/2544493003/

Move QuicAckListenerInterface, QuicPendingRetransmission, and
QuicTransmissionInfo out of quic_packets.{h,cc}. No behavior change.

Merge internal change: 139371729

https://codereview.chromium.org/2531163009/

Print out detailed_error_ in various LOG statements in QuicFramer.

Merge internal change: 139361927

https://codereview.chromium.org/2540873002/

Add ENDPOINT macro to QuicFramer (and include in existing LOG statement output).

Merge internal change: 139353951

https://codereview.chromium.org/2533303004/

Rename QuicInMemoryCache to QuicHttpResponseCache.

Merge internal change: 139246544

https://codereview.chromium.org/2532083005/

Rename quic_protocol to quic_packets. No behavior change.

Merge internal change: 139216821

https://codereview.chromium.org/2541673002/

Move remaining tests from quic_protocol_test.cc into appropriate locations. 
These were missed during previous refactors.

Merge internal change: 139210181

https://codereview.chromium.org/2534253002/

Remove uses of gfe2::test::GenerateBody from QUIC code and use the string fill
constructor instead.

Merge internal change: 139197459

https://codereview.chromium.org/2536033004/

QUIC - bugfix for forced head of line blocking experiment. Guarded by ENABLED
--FLAGS_quic_bugfix_fhol_writev_fin_only_v2.

Fix bugs in FHOL:
o handle fin-only writev correctly.
o limit additional buffering to one HTTP/2 Data frame (~16KB).
o make headers stream flow control a large fixed size, rather than
using autotuning.

This is a redo of internal change 134345701, the only difference being
the headers stream flow control window size.

Merge internal change: 136086759

https://codereview.chromium.org/2535373002/

Split out QUIC frame definitions into quic_frames. No behavior change.

Merge internal change: 139196641

https://codereview.chromium.org/2537233002/

Remove unnecessary virtual keyword from QuicDefaultPacketWriter. No behavior
change.

Merge internal change: 139192665

https://codereview.chromium.org/2537753004/

Add QUIC client connection options.  Only respected on the client side. No
functional change.  Protected by ENABLED FLAGS_quic_client_connection_options.

Existing users of HasClientSentConnectionOptions are unchanged in order
to preserve existing behavior.  New users use
HasClientRequestedIndependentOption.

Merge internal change: 139159621

https://codereview.chromium.org/2537543005/

Move QuicVersionManager into standalone .h/.cc. No behavior change.

Merge internal change: 139117022

https://codereview.chromium.org/2535283002/

R=rch@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Landing Recent QUIC changes until Fri Nov 18 23:21:04 2016 +0000

Remove the "New" prefix from various Ack-related structs/methods in QuicFramer
now that there are only "new" acks.

Merge internal change: 139629781

https://codereview.chromium.org/2543953003/

Delete unused QuicData::owns_buffer method. No behavior change.

Merge internal change: 139611586

https://codereview.chromium.org/2544033002/

Split up quic_frames.{h,cc} into files for each frame type.

Merge internal change: 139607554

https://codereview.chromium.org/2545543003/

Fix MSAN failure due to reading from an uninitialized variable. No functional
change (the variable is not used in uninitialized state).

Merge internal change: 139593422

https://codereview.chromium.org/2546583002/

Move PacketTimeVector typedef to quic_types.h. No behavior change.

Merge internal change: 139577765

https://codereview.chromium.org/2541233002/

Remove unnecessary (and incorrectly named) MaybeRemoveTransmittableFrames
method. No behavior change.

MaybeRemoveRetransmittableFrames is only called from inside
RemoveRetransmittability, and it unconditionally removes frames, no
"maybe" about it :-)

Merge internal change: 139571201

https://codereview.chromium.org/2535753006/

Remove call to SetMaxPacketLength from QuicPacketCreator::OnSerializedPacket, as
it will always be a no-op/early return. No behavior change.

Calling SetMaxPacketLength with max_packet_length_ as the argument hits
the early return here:

https://chromium.googlesource.com/chromium/src/+/bdbe864eb7ecdf545a6f6a63b635...

Merge internal change: 139571059

https://codereview.chromium.org/2543833003/

Allow congestion controller state to be accessed by the debug visitors.

Merge internal change: 139513656

https://codereview.chromium.org/2540143003/

Implement pretty-printer for QuicConnectionStats

This function was declared in the header file, but didn't seem to be
defined anywhere?  I plan to use this function in an upcoming CL for
exercising various congestion-control algorithms.

Merge internal change: 139496268

https://codereview.chromium.org/2543813002/

Construct QuicFrames vectors directly in QuicFramerTest.

Merge internal change: 139492573

https://codereview.chromium.org/2538243002/

Delete unused index variable. No behavior change.

Merge internal change: 139492399

https://codereview.chromium.org/2543463005/

Make QuicClientBase::WaitForCryptoHandshakeComplete return false if the
handshake fails. There's currently no verification that the handshake has
succeeded when this method returns, resulting in buggy tests.

Merge internal change: 139469341

https://codereview.chromium.org/2542743003/

Write a regression test demonstrating that a QuicCryptoClientStream can receive
and use a server config update with a valid certs and proofs.

Merge internal change: 139457701

https://codereview.chromium.org/2538923003/

Fix a bug in the handling of SCUP messages in QUIC clients.

Merge internal change: 139373466

https://codereview.chromium.org/2544493003/

Move QuicAckListenerInterface, QuicPendingRetransmission, and
QuicTransmissionInfo out of quic_packets.{h,cc}. No behavior change.

Merge internal change: 139371729

https://codereview.chromium.org/2531163009/

Print out detailed_error_ in various LOG statements in QuicFramer.

Merge internal change: 139361927

https://codereview.chromium.org/2540873002/

Add ENDPOINT macro to QuicFramer (and include in existing LOG statement output).

Merge internal change: 139353951

https://codereview.chromium.org/2533303004/

Rename QuicInMemoryCache to QuicHttpResponseCache.

Merge internal change: 139246544

https://codereview.chromium.org/2532083005/

Rename quic_protocol to quic_packets. No behavior change.

Merge internal change: 139216821

https://codereview.chromium.org/2541673002/

Move remaining tests from quic_protocol_test.cc into appropriate locations. 
These were missed during previous refactors.

Merge internal change: 139210181

https://codereview.chromium.org/2534253002/

Remove uses of gfe2::test::GenerateBody from QUIC code and use the string fill
constructor instead.

Merge internal change: 139197459

https://codereview.chromium.org/2536033004/

QUIC - bugfix for forced head of line blocking experiment. Guarded by ENABLED
--FLAGS_quic_bugfix_fhol_writev_fin_only_v2.

Fix bugs in FHOL:
o handle fin-only writev correctly.
o limit additional buffering to one HTTP/2 Data frame (~16KB).
o make headers stream flow control a large fixed size, rather than
using autotuning.

This is a redo of internal change 134345701, the only difference being
the headers stream flow control window size.

Merge internal change: 136086759

https://codereview.chromium.org/2535373002/

Split out QUIC frame definitions into quic_frames. No behavior change.

Merge internal change: 139196641

https://codereview.chromium.org/2537233002/

Remove unnecessary virtual keyword from QuicDefaultPacketWriter. No behavior
change.

Merge internal change: 139192665

https://codereview.chromium.org/2537753004/

Add QUIC client connection options.  Only respected on the client side. No
functional change.  Protected by ENABLED FLAGS_quic_client_connection_options.

Existing users of HasClientSentConnectionOptions are unchanged in order
to preserve existing behavior.  New users use
HasClientRequestedIndependentOption.

Merge internal change: 139159621

https://codereview.chromium.org/2537543005/

Move QuicVersionManager into standalone .h/.cc. No behavior change.

Merge internal change: 139117022

https://codereview.chromium.org/2535283002/

R=rch@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[commit-bot: I haz the power, 2016-12-01 21:38:40]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-01 21:40:15]

Description was changed from

==========
Landing Recent QUIC changes until Fri Nov 18 23:21:04 2016 +0000

Remove the "New" prefix from various Ack-related structs/methods in QuicFramer
now that there are only "new" acks.

Merge internal change: 139629781

https://codereview.chromium.org/2543953003/

Delete unused QuicData::owns_buffer method. No behavior change.

Merge internal change: 139611586

https://codereview.chromium.org/2544033002/

Split up quic_frames.{h,cc} into files for each frame type.

Merge internal change: 139607554

https://codereview.chromium.org/2545543003/

Fix MSAN failure due to reading from an uninitialized variable. No functional
change (the variable is not used in uninitialized state).

Merge internal change: 139593422

https://codereview.chromium.org/2546583002/

Move PacketTimeVector typedef to quic_types.h. No behavior change.

Merge internal change: 139577765

https://codereview.chromium.org/2541233002/

Remove unnecessary (and incorrectly named) MaybeRemoveTransmittableFrames
method. No behavior change.

MaybeRemoveRetransmittableFrames is only called from inside
RemoveRetransmittability, and it unconditionally removes frames, no
"maybe" about it :-)

Merge internal change: 139571201

https://codereview.chromium.org/2535753006/

Remove call to SetMaxPacketLength from QuicPacketCreator::OnSerializedPacket, as
it will always be a no-op/early return. No behavior change.

Calling SetMaxPacketLength with max_packet_length_ as the argument hits
the early return here:

https://chromium.googlesource.com/chromium/src/+/bdbe864eb7ecdf545a6f6a63b635...

Merge internal change: 139571059

https://codereview.chromium.org/2543833003/

Allow congestion controller state to be accessed by the debug visitors.

Merge internal change: 139513656

https://codereview.chromium.org/2540143003/

Implement pretty-printer for QuicConnectionStats

This function was declared in the header file, but didn't seem to be
defined anywhere?  I plan to use this function in an upcoming CL for
exercising various congestion-control algorithms.

Merge internal change: 139496268

https://codereview.chromium.org/2543813002/

Construct QuicFrames vectors directly in QuicFramerTest.

Merge internal change: 139492573

https://codereview.chromium.org/2538243002/

Delete unused index variable. No behavior change.

Merge internal change: 139492399

https://codereview.chromium.org/2543463005/

Make QuicClientBase::WaitForCryptoHandshakeComplete return false if the
handshake fails. There's currently no verification that the handshake has
succeeded when this method returns, resulting in buggy tests.

Merge internal change: 139469341

https://codereview.chromium.org/2542743003/

Write a regression test demonstrating that a QuicCryptoClientStream can receive
and use a server config update with a valid certs and proofs.

Merge internal change: 139457701

https://codereview.chromium.org/2538923003/

Fix a bug in the handling of SCUP messages in QUIC clients.

Merge internal change: 139373466

https://codereview.chromium.org/2544493003/

Move QuicAckListenerInterface, QuicPendingRetransmission, and
QuicTransmissionInfo out of quic_packets.{h,cc}. No behavior change.

Merge internal change: 139371729

https://codereview.chromium.org/2531163009/

Print out detailed_error_ in various LOG statements in QuicFramer.

Merge internal change: 139361927

https://codereview.chromium.org/2540873002/

Add ENDPOINT macro to QuicFramer (and include in existing LOG statement output).

Merge internal change: 139353951

https://codereview.chromium.org/2533303004/

Rename QuicInMemoryCache to QuicHttpResponseCache.

Merge internal change: 139246544

https://codereview.chromium.org/2532083005/

Rename quic_protocol to quic_packets. No behavior change.

Merge internal change: 139216821

https://codereview.chromium.org/2541673002/

Move remaining tests from quic_protocol_test.cc into appropriate locations. 
These were missed during previous refactors.

Merge internal change: 139210181

https://codereview.chromium.org/2534253002/

Remove uses of gfe2::test::GenerateBody from QUIC code and use the string fill
constructor instead.

Merge internal change: 139197459

https://codereview.chromium.org/2536033004/

QUIC - bugfix for forced head of line blocking experiment. Guarded by ENABLED
--FLAGS_quic_bugfix_fhol_writev_fin_only_v2.

Fix bugs in FHOL:
o handle fin-only writev correctly.
o limit additional buffering to one HTTP/2 Data frame (~16KB).
o make headers stream flow control a large fixed size, rather than
using autotuning.

This is a redo of internal change 134345701, the only difference being
the headers stream flow control window size.

Merge internal change: 136086759

https://codereview.chromium.org/2535373002/

Split out QUIC frame definitions into quic_frames. No behavior change.

Merge internal change: 139196641

https://codereview.chromium.org/2537233002/

Remove unnecessary virtual keyword from QuicDefaultPacketWriter. No behavior
change.

Merge internal change: 139192665

https://codereview.chromium.org/2537753004/

Add QUIC client connection options.  Only respected on the client side. No
functional change.  Protected by ENABLED FLAGS_quic_client_connection_options.

Existing users of HasClientSentConnectionOptions are unchanged in order
to preserve existing behavior.  New users use
HasClientRequestedIndependentOption.

Merge internal change: 139159621

https://codereview.chromium.org/2537543005/

Move QuicVersionManager into standalone .h/.cc. No behavior change.

Merge internal change: 139117022

https://codereview.chromium.org/2535283002/

R=rch@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Landing Recent QUIC changes until Fri Nov 18 23:21:04 2016 +0000

Remove the "New" prefix from various Ack-related structs/methods in QuicFramer
now that there are only "new" acks.

Merge internal change: 139629781

https://codereview.chromium.org/2543953003/

Delete unused QuicData::owns_buffer method. No behavior change.

Merge internal change: 139611586

https://codereview.chromium.org/2544033002/

Split up quic_frames.{h,cc} into files for each frame type.

Merge internal change: 139607554

https://codereview.chromium.org/2545543003/

Fix MSAN failure due to reading from an uninitialized variable. No functional
change (the variable is not used in uninitialized state).

Merge internal change: 139593422

https://codereview.chromium.org/2546583002/

Move PacketTimeVector typedef to quic_types.h. No behavior change.

Merge internal change: 139577765

https://codereview.chromium.org/2541233002/

Remove unnecessary (and incorrectly named) MaybeRemoveTransmittableFrames
method. No behavior change.

MaybeRemoveRetransmittableFrames is only called from inside
RemoveRetransmittability, and it unconditionally removes frames, no
"maybe" about it :-)

Merge internal change: 139571201

https://codereview.chromium.org/2535753006/

Remove call to SetMaxPacketLength from QuicPacketCreator::OnSerializedPacket, as
it will always be a no-op/early return. No behavior change.

Calling SetMaxPacketLength with max_packet_length_ as the argument hits
the early return here:

https://chromium.googlesource.com/chromium/src/+/bdbe864eb7ecdf545a6f6a63b635...

Merge internal change: 139571059

https://codereview.chromium.org/2543833003/

Allow congestion controller state to be accessed by the debug visitors.

Merge internal change: 139513656

https://codereview.chromium.org/2540143003/

Implement pretty-printer for QuicConnectionStats

This function was declared in the header file, but didn't seem to be
defined anywhere?  I plan to use this function in an upcoming CL for
exercising various congestion-control algorithms.

Merge internal change: 139496268

https://codereview.chromium.org/2543813002/

Construct QuicFrames vectors directly in QuicFramerTest.

Merge internal change: 139492573

https://codereview.chromium.org/2538243002/

Delete unused index variable. No behavior change.

Merge internal change: 139492399

https://codereview.chromium.org/2543463005/

Make QuicClientBase::WaitForCryptoHandshakeComplete return false if the
handshake fails. There's currently no verification that the handshake has
succeeded when this method returns, resulting in buggy tests.

Merge internal change: 139469341

https://codereview.chromium.org/2542743003/

Write a regression test demonstrating that a QuicCryptoClientStream can receive
and use a server config update with a valid certs and proofs.

Merge internal change: 139457701

https://codereview.chromium.org/2538923003/

Fix a bug in the handling of SCUP messages in QUIC clients.

Merge internal change: 139373466

https://codereview.chromium.org/2544493003/

Move QuicAckListenerInterface, QuicPendingRetransmission, and
QuicTransmissionInfo out of quic_packets.{h,cc}. No behavior change.

Merge internal change: 139371729

https://codereview.chromium.org/2531163009/

Print out detailed_error_ in various LOG statements in QuicFramer.

Merge internal change: 139361927

https://codereview.chromium.org/2540873002/

Add ENDPOINT macro to QuicFramer (and include in existing LOG statement output).

Merge internal change: 139353951

https://codereview.chromium.org/2533303004/

Rename QuicInMemoryCache to QuicHttpResponseCache.

Merge internal change: 139246544

https://codereview.chromium.org/2532083005/

Rename quic_protocol to quic_packets. No behavior change.

Merge internal change: 139216821

https://codereview.chromium.org/2541673002/

Move remaining tests from quic_protocol_test.cc into appropriate locations. 
These were missed during previous refactors.

Merge internal change: 139210181

https://codereview.chromium.org/2534253002/

Remove uses of gfe2::test::GenerateBody from QUIC code and use the string fill
constructor instead.

Merge internal change: 139197459

https://codereview.chromium.org/2536033004/

QUIC - bugfix for forced head of line blocking experiment. Guarded by ENABLED
--FLAGS_quic_bugfix_fhol_writev_fin_only_v2.

Fix bugs in FHOL:
o handle fin-only writev correctly.
o limit additional buffering to one HTTP/2 Data frame (~16KB).
o make headers stream flow control a large fixed size, rather than
using autotuning.

This is a redo of internal change 134345701, the only difference being
the headers stream flow control window size.

Merge internal change: 136086759

https://codereview.chromium.org/2535373002/

Split out QUIC frame definitions into quic_frames. No behavior change.

Merge internal change: 139196641

https://codereview.chromium.org/2537233002/

Remove unnecessary virtual keyword from QuicDefaultPacketWriter. No behavior
change.

Merge internal change: 139192665

https://codereview.chromium.org/2537753004/

Add QUIC client connection options.  Only respected on the client side. No
functional change.  Protected by ENABLED FLAGS_quic_client_connection_options.

Existing users of HasClientSentConnectionOptions are unchanged in order
to preserve existing behavior.  New users use
HasClientRequestedIndependentOption.

Merge internal change: 139159621

https://codereview.chromium.org/2537543005/

Move QuicVersionManager into standalone .h/.cc. No behavior change.

Merge internal change: 139117022

https://codereview.chromium.org/2535283002/

R=rch@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Committed: https://crrev.com/28270e8feac1cc094dff71351042f1d7fdb1d4e2
Cr-Commit-Position: refs/heads/master@{#435721}
==========

[commit-bot: I haz the power, 2016-12-01 21:40:17]

Patchset 5 (id:??) landed as
https://crrev.com/28270e8feac1cc094dff71351042f1d7fdb1d4e2
Cr-Commit-Position: refs/heads/master@{#435721}