Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2547573002:
Rename "interface" to "codec_interface" in video_track_recorder.cc. (Closed)
DescriptionRename "interface" to "codec_interface" in video_track_recorder.cc.
"interface" is defined as "struct" in basetyps.h in Windows SDK, so if this
header is included in video_track_recorder.cc, we will get compile error for
variables named "interface".
content/renderer depends on ui/base/ime. When I tried to add struct traits for
some IME related structs, it caused video_track_recorder.cc to somehow include
Windows SDK's RPC related header files, which indirectly included basetyps.h,
which caused compile errors in Windows.
Renaming this variable fixes the problem.
BUG=NONE
Committed: https://crrev.com/b62d8bee558e0fdd36cdad96ccf2fa2e3497b606
Cr-Commit-Position: refs/heads/master@{#436012}
Patch Set 1 #
Messages
Total messages: 18 (11 generated)
The CQ bit was checked by moshayedi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Rename "interface" to "codec_interface" in video_track_recorder.cc. "interface" is defined as "struct" in basetyps.h in Windows SDK, so if this header is included in video_track_recorder.cc, we will get compile error for variables named "interface". content/renderer depends on ui/base/ime. When I tried to add struct traits for some IME related structs, it caused video_track_recorder.cc to somehow include Windows SDK's RPC related header files, which indirectly included basetyps.h, which caused compile error in Windows. Renaming this variable fixes the problem. BUG=NONE ========== to ========== Rename "interface" to "codec_interface" in video_track_recorder.cc. "interface" is defined as "struct" in basetyps.h in Windows SDK, so if this header is included in video_track_recorder.cc, we will get compile error for variables named "interface". content/renderer depends on ui/base/ime. When I tried to add struct traits for some IME related structs, it caused video_track_recorder.cc to somehow include Windows SDK's RPC related header files, which indirectly included basetyps.h, which caused compile errors in Windows. Renaming this variable fixes the problem. BUG=NONE ==========
moshayedi@chromium.org changed reviewers: + miu@chromium.org
PTAL. This fixes the windows compile errors I was getting at https://codereview.chromium.org/2539453002/ in earlier patch sets. Thanks.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
tsepez@chromium.org changed reviewers: + tsepez@chromium.org
rs lgtm on renaming.
miu@ can you please provide OWNERS review? Thanks.
lgtm
The CQ bit was checked by miu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480705706566920, "parent_rev":
"2f78e471bff589af86d46d287ca840151616e924", "commit_rev":
"04b17024786a9b208614b4e9ee5fd470e63edd26"}
Message was sent while issue was closed.
Description was changed from ========== Rename "interface" to "codec_interface" in video_track_recorder.cc. "interface" is defined as "struct" in basetyps.h in Windows SDK, so if this header is included in video_track_recorder.cc, we will get compile error for variables named "interface". content/renderer depends on ui/base/ime. When I tried to add struct traits for some IME related structs, it caused video_track_recorder.cc to somehow include Windows SDK's RPC related header files, which indirectly included basetyps.h, which caused compile errors in Windows. Renaming this variable fixes the problem. BUG=NONE ========== to ========== Rename "interface" to "codec_interface" in video_track_recorder.cc. "interface" is defined as "struct" in basetyps.h in Windows SDK, so if this header is included in video_track_recorder.cc, we will get compile error for variables named "interface". content/renderer depends on ui/base/ime. When I tried to add struct traits for some IME related structs, it caused video_track_recorder.cc to somehow include Windows SDK's RPC related header files, which indirectly included basetyps.h, which caused compile errors in Windows. Renaming this variable fixes the problem. BUG=NONE ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Rename "interface" to "codec_interface" in video_track_recorder.cc. "interface" is defined as "struct" in basetyps.h in Windows SDK, so if this header is included in video_track_recorder.cc, we will get compile error for variables named "interface". content/renderer depends on ui/base/ime. When I tried to add struct traits for some IME related structs, it caused video_track_recorder.cc to somehow include Windows SDK's RPC related header files, which indirectly included basetyps.h, which caused compile errors in Windows. Renaming this variable fixes the problem. BUG=NONE ========== to ========== Rename "interface" to "codec_interface" in video_track_recorder.cc. "interface" is defined as "struct" in basetyps.h in Windows SDK, so if this header is included in video_track_recorder.cc, we will get compile error for variables named "interface". content/renderer depends on ui/base/ime. When I tried to add struct traits for some IME related structs, it caused video_track_recorder.cc to somehow include Windows SDK's RPC related header files, which indirectly included basetyps.h, which caused compile errors in Windows. Renaming this variable fixes the problem. BUG=NONE Committed: https://crrev.com/b62d8bee558e0fdd36cdad96ccf2fa2e3497b606 Cr-Commit-Position: refs/heads/master@{#436012} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b62d8bee558e0fdd36cdad96ccf2fa2e3497b606 Cr-Commit-Position: refs/heads/master@{#436012} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
