Unflag the MediaDevices devicechange event in Blink.

Unflag the MediaDevices devicechange event in Blink.

The feature is still disabled on Android because SystemMonitor is not
yet supported on that platform.

Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/s-w44wOMzqs

BUG=585096
Committed: https://crrev.com/aed5726916ac7fd5d040e8832a3fe6b4a47342c5
Cr-Commit-Position: refs/heads/master@{#436324}

[Guido Urdaneta, 2016-12-01 16:25:39]

The CQ bit was checked by guidou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 16:26:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Guido Urdaneta, 2016-12-01 16:27:06]

Description was changed from

==========
Unflag the MediaDevices devicechange event in Blink.

The feature is still disabled on Android because SystemMonitor is not
yet supported on that platform.

BUG=585096
==========

to

==========
Unflag the MediaDevices devicechange event in Blink.

The feature is still disabled on Android because SystemMonitor is not
yet supported on that platform.

Intent to ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/s-w44wOMzqs

BUG=585096
==========

[commit-bot: I haz the power, 2016-12-01 16:42:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 16:42:16]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Guido Urdaneta, 2016-12-01 16:48:27]

The CQ bit was checked by guidou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 16:48:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Guido Urdaneta, 2016-12-01 17:32:49]

guidou@chromium.org changed reviewers:
+ esprehn@chromium.org, foolip@chromium.org

[Guido Urdaneta, 2016-12-01 17:32:50]

Hi, PTAL

[commit-bot: I haz the power, 2016-12-01 18:21:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 18:21:08]

Dry run: This issue passed the CQ dry run.

[foolip, 2016-12-02 08:48:26]

lgtm % nit

https://codereview.chromium.org/2547563002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediastream/MediaDevices.cpp (left):

https://codereview.chromium.org/2547563002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediastream/MediaDevices.cpp:147: if
(RuntimeEnabledFeatures::onDeviceChangeEnabled())
Can you DCHECK(RuntimeEnabledFeatures::onDeviceChangeEnabled()) instead?

[Guido Urdaneta, 2016-12-02 09:29:15]

Patchset #1 (id:1) has been deleted

[Guido Urdaneta, 2016-12-02 09:31:01]

https://codereview.chromium.org/2547563002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediastream/MediaDevices.cpp (left):

https://codereview.chromium.org/2547563002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediastream/MediaDevices.cpp:147: if
(RuntimeEnabledFeatures::onDeviceChangeEnabled())
On 2016/12/02 08:48:26, foolip wrote:
> Can you DCHECK(RuntimeEnabledFeatures::onDeviceChangeEnabled()) instead?

Restored the original since the flag hasn't actually been removed, just made
stable in most platforms.

[Guido Urdaneta, 2016-12-02 09:32:10]

The CQ bit was checked by guidou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 09:32:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 11:29:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 11:29:55]

Dry run: This issue passed the CQ dry run.

[Guido Urdaneta, 2016-12-02 17:34:07]

esprehn@: can you rs? (feel free to do a full review though)

[Guido Urdaneta, 2016-12-05 14:30:02]

guidou@chromium.org changed reviewers:
+ jochen@chromium.org
- esprehn@chromium.org

[Guido Urdaneta, 2016-12-05 14:30:24]

jochen@: can you rs?

[jochen (gone - plz use gerrit), 2016-12-05 15:21:22]

lgtm

[Guido Urdaneta, 2016-12-05 15:22:06]

The CQ bit was checked by guidou@chromium.org

[Guido Urdaneta, 2016-12-05 15:22:06]

The patchset sent to the CQ was uploaded after l-g-t-m from foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2547563002/#ps40001
(title: "restore MediaDevices.cpp")

[commit-bot: I haz the power, 2016-12-05 15:22:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 15:24:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 15:24:35]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Guido Urdaneta, 2016-12-05 15:29:58]

The CQ bit was checked by guidou@chromium.org

[Guido Urdaneta, 2016-12-05 15:29:58]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2547563002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-05 15:30:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 16:56:34]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480951798485200,
"parent_rev": "08e3b3e8b4c959aa57b6c90b6bb3459bf6fba7aa", "commit_rev":
"4fa0ae11ec97bf8180c70c9de0786b803440ab5a"}

[commit-bot: I haz the power, 2016-12-05 16:57:04]

Description was changed from

==========
Unflag the MediaDevices devicechange event in Blink.

The feature is still disabled on Android because SystemMonitor is not
yet supported on that platform.

Intent to ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/s-w44wOMzqs

BUG=585096
==========

to

==========
Unflag the MediaDevices devicechange event in Blink.

The feature is still disabled on Android because SystemMonitor is not
yet supported on that platform.

Intent to ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/s-w44wOMzqs

BUG=585096
==========

[commit-bot: I haz the power, 2016-12-05 16:57:05]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-12-05 16:59:37]

Description was changed from

==========
Unflag the MediaDevices devicechange event in Blink.

The feature is still disabled on Android because SystemMonitor is not
yet supported on that platform.

Intent to ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/s-w44wOMzqs

BUG=585096
==========

to

==========
Unflag the MediaDevices devicechange event in Blink.

The feature is still disabled on Android because SystemMonitor is not
yet supported on that platform.

Intent to ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/s-w44wOMzqs

BUG=585096

Committed: https://crrev.com/aed5726916ac7fd5d040e8832a3fe6b4a47342c5
Cr-Commit-Position: refs/heads/master@{#436324}
==========

[commit-bot: I haz the power, 2016-12-05 16:59:38]

Patchset 3 (id:??) landed as
https://crrev.com/aed5726916ac7fd5d040e8832a3fe6b4a47342c5
Cr-Commit-Position: refs/heads/master@{#436324}