Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2547533002: Add flags to enable screen orientation lock for fullscreen video on Android. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 2083 matching lines...) Expand 10 before | Expand all | Expand 10 after
2094 IDS_FLAGS_CROSS_PROCESS_GUEST_VIEW_ISOLATION_DESCRIPTION, kOsDesktop, 2094 IDS_FLAGS_CROSS_PROCESS_GUEST_VIEW_ISOLATION_DESCRIPTION, kOsDesktop,
2095 FEATURE_VALUE_TYPE(features::kGuestViewCrossProcessFrames)}, 2095 FEATURE_VALUE_TYPE(features::kGuestViewCrossProcessFrames)},
2096 #if !defined(OS_ANDROID) && !defined(OS_IOS) 2096 #if !defined(OS_ANDROID) && !defined(OS_IOS)
2097 {"media-remoting", IDS_FLAGS_MEDIA_REMOTING_NAME, 2097 {"media-remoting", IDS_FLAGS_MEDIA_REMOTING_NAME,
2098 IDS_FLAGS_MEDIA_REMOTING_DESCRIPTION, kOsDesktop, 2098 IDS_FLAGS_MEDIA_REMOTING_DESCRIPTION, kOsDesktop,
2099 FEATURE_VALUE_TYPE(features::kMediaRemoting)}, 2099 FEATURE_VALUE_TYPE(features::kMediaRemoting)},
2100 {"media-remoting-encrypted", IDS_FLAGS_MEDIA_REMOTING_ENCRYPTED_NAME, 2100 {"media-remoting-encrypted", IDS_FLAGS_MEDIA_REMOTING_ENCRYPTED_NAME,
2101 IDS_FLAGS_MEDIA_REMOTING_ENCRYPTED_DESCRIPTION, kOsDesktop, 2101 IDS_FLAGS_MEDIA_REMOTING_ENCRYPTED_DESCRIPTION, kOsDesktop,
2102 FEATURE_VALUE_TYPE(features::kMediaRemotingEncrypted)}, 2102 FEATURE_VALUE_TYPE(features::kMediaRemotingEncrypted)},
2103 #endif 2103 #endif
2104 #if defined(OS_ANDROID)
2105 {"video-fullscreen-orientation-lock",
2106 IDS_FLAGS_VIDEO_FULLSCREEN_ORIENTATION_LOCK_NAME,
2107 IDS_FLAGS_VIDEO_FULLSCREEN_ORIENTATION_LOCK_DESCRIPTION, kOsAndroid,
2108 FEATURE_VALUE_TYPE(features::kVideoFullscreenOrientationLock)},
2109 #endif
2104 2110
2105 // NOTE: Adding new command-line switches requires adding corresponding 2111 // NOTE: Adding new command-line switches requires adding corresponding
2106 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 2112 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
2107 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 2113 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
2108 }; 2114 };
2109 2115
2110 class FlagsStateSingleton { 2116 class FlagsStateSingleton {
2111 public: 2117 public:
2112 FlagsStateSingleton() 2118 FlagsStateSingleton()
2113 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {} 2119 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {}
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
2303 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2309 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2304 2310
2305 const FeatureEntry* GetFeatureEntries(size_t* count) { 2311 const FeatureEntry* GetFeatureEntries(size_t* count) {
2306 *count = arraysize(kFeatureEntries); 2312 *count = arraysize(kFeatureEntries);
2307 return kFeatureEntries; 2313 return kFeatureEntries;
2308 } 2314 }
2309 2315
2310 } // namespace testing 2316 } // namespace testing
2311 2317
2312 } // namespace about_flags 2318 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698