[Extensions] Allow shared resources between tests via _test_resources

[Extensions] Allow shared resources between tests via _test_resources

Allow tests to override extension protocols so that tests can include
shared resources via chrome-extension://<id>/_test_resources/foo (which
maps to chrome/test/data/extensions/foo). This allows tests to include
utility files in a "#include" style fashion with e.g.
<script src="_test_resources/common_utility.js"></script>

This removes the need to duplicate a bunch of files between different
test extensions.  Looking longer term, this could also allow us to
remove a number of our chrome.test methods that are purely JS-based
(we could have them in a common "extension_test.js" file). This is
good for a number of reasons, outlined in the bug.

Set up the overrides and utilize it in the webnavigation API tests,
taking out the common framework.js file for a net savings of around
6k lines.

BUG=670741
Committed: https://crrev.com/647dc9d1109f473f7cf069c3ba019dee5a4e062c
Cr-Commit-Position: refs/heads/master@{#436172}

[Devlin, 2016-12-02 02:28:36]

Description was changed from

==========
formatted


woot

BUG=
==========

to

==========
[Extensions] Allow shared resources between tests via _test_resources

Allow tests to override extension protocols so that tests can include
shared resources via chrome-extension://<id>/_test_resources/foo (which
maps to chrome/test/data/extensions/foo). This allows tests to include
utility files in a "#include" style fashion with e.g.
<script src="_test_resources/common_utility.js"></script>

This removes the need to duplicate a bunch of files between different
test extensions.  Looking longer term, this could also allow us to
remove a number of our chrome.test methods that are purely JS-based
(we could have them in a common "extension_test.js" file). This is
good for a number of reasons, outlined in the bug.

Set up the overrides and utilize it in the webnavigation API tests,
taking out the common framework.js file for a net savings of around
6k lines.

BUG=TODO
==========

[Devlin, 2016-12-02 02:29:56]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 02:30:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 03:20:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 03:20:07]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-12-02 03:39:34]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org, nasko@chromium.org

[Devlin, 2016-12-02 03:39:35]

Hey folks, mind taking a look?
+Nasko since his need prompted this and he had the good idea to hook into
protocols (and as owner of web navigation).
+Istiaque for extensions
+Dan as fyi since we had previously talked about this

[nasko, 2016-12-02 15:15:15]

Awesome! I love how simple it turns out to be and that we don't have to made
changes to permissions or introduce difference in behavior between reality and
tests.

LGTM!

[Devlin, 2016-12-02 17:12:29]

Description was changed from

==========
[Extensions] Allow shared resources between tests via _test_resources

Allow tests to override extension protocols so that tests can include
shared resources via chrome-extension://<id>/_test_resources/foo (which
maps to chrome/test/data/extensions/foo). This allows tests to include
utility files in a "#include" style fashion with e.g.
<script src="_test_resources/common_utility.js"></script>

This removes the need to duplicate a bunch of files between different
test extensions.  Looking longer term, this could also allow us to
remove a number of our chrome.test methods that are purely JS-based
(we could have them in a common "extension_test.js" file). This is
good for a number of reasons, outlined in the bug.

Set up the overrides and utilize it in the webnavigation API tests,
taking out the common framework.js file for a net savings of around
6k lines.

BUG=TODO
==========

to

==========
[Extensions] Allow shared resources between tests via _test_resources

Allow tests to override extension protocols so that tests can include
shared resources via chrome-extension://<id>/_test_resources/foo (which
maps to chrome/test/data/extensions/foo). This allows tests to include
utility files in a "#include" style fashion with e.g.
<script src="_test_resources/common_utility.js"></script>

This removes the need to duplicate a bunch of files between different
test extensions.  Looking longer term, this could also allow us to
remove a number of our chrome.test methods that are purely JS-based
(we could have them in a common "extension_test.js" file). This is
good for a number of reasons, outlined in the bug.

Set up the overrides and utilize it in the webnavigation API tests,
taking out the common framework.js file for a net savings of around
6k lines.

BUG=670741
==========

[lazyboy, 2016-12-03 04:00:10]

lgtm

[Devlin, 2016-12-03 05:03:12]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-12-03 05:03:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-03 21:04:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480741392822920,
"parent_rev": "da6ac858072cf7b7be97cb42afedb0c8085a1b1c", "commit_rev":
"4918da1f7b4853059605e25b95d045ad82b13cd4"}

[commit-bot: I haz the power, 2016-12-03 21:04:29]

Description was changed from

==========
[Extensions] Allow shared resources between tests via _test_resources

Allow tests to override extension protocols so that tests can include
shared resources via chrome-extension://<id>/_test_resources/foo (which
maps to chrome/test/data/extensions/foo). This allows tests to include
utility files in a "#include" style fashion with e.g.
<script src="_test_resources/common_utility.js"></script>

This removes the need to duplicate a bunch of files between different
test extensions.  Looking longer term, this could also allow us to
remove a number of our chrome.test methods that are purely JS-based
(we could have them in a common "extension_test.js" file). This is
good for a number of reasons, outlined in the bug.

Set up the overrides and utilize it in the webnavigation API tests,
taking out the common framework.js file for a net savings of around
6k lines.

BUG=670741
==========

to

==========
[Extensions] Allow shared resources between tests via _test_resources

Allow tests to override extension protocols so that tests can include
shared resources via chrome-extension://<id>/_test_resources/foo (which
maps to chrome/test/data/extensions/foo). This allows tests to include
utility files in a "#include" style fashion with e.g.
<script src="_test_resources/common_utility.js"></script>

This removes the need to duplicate a bunch of files between different
test extensions.  Looking longer term, this could also allow us to
remove a number of our chrome.test methods that are purely JS-based
(we could have them in a common "extension_test.js" file). This is
good for a number of reasons, outlined in the bug.

Set up the overrides and utilize it in the webnavigation API tests,
taking out the common framework.js file for a net savings of around
6k lines.

BUG=670741
==========

[commit-bot: I haz the power, 2016-12-03 21:04:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-03 21:05:50]

Description was changed from

==========
[Extensions] Allow shared resources between tests via _test_resources

Allow tests to override extension protocols so that tests can include
shared resources via chrome-extension://<id>/_test_resources/foo (which
maps to chrome/test/data/extensions/foo). This allows tests to include
utility files in a "#include" style fashion with e.g.
<script src="_test_resources/common_utility.js"></script>

This removes the need to duplicate a bunch of files between different
test extensions.  Looking longer term, this could also allow us to
remove a number of our chrome.test methods that are purely JS-based
(we could have them in a common "extension_test.js" file). This is
good for a number of reasons, outlined in the bug.

Set up the overrides and utilize it in the webnavigation API tests,
taking out the common framework.js file for a net savings of around
6k lines.

BUG=670741
==========

to

==========
[Extensions] Allow shared resources between tests via _test_resources

Allow tests to override extension protocols so that tests can include
shared resources via chrome-extension://<id>/_test_resources/foo (which
maps to chrome/test/data/extensions/foo). This allows tests to include
utility files in a "#include" style fashion with e.g.
<script src="_test_resources/common_utility.js"></script>

This removes the need to duplicate a bunch of files between different
test extensions.  Looking longer term, this could also allow us to
remove a number of our chrome.test methods that are purely JS-based
(we could have them in a common "extension_test.js" file). This is
good for a number of reasons, outlined in the bug.

Set up the overrides and utilize it in the webnavigation API tests,
taking out the common framework.js file for a net savings of around
6k lines.

BUG=670741

Committed: https://crrev.com/647dc9d1109f473f7cf069c3ba019dee5a4e062c
Cr-Commit-Position: refs/heads/master@{#436172}
==========

[commit-bot: I haz the power, 2016-12-03 21:05:52]

Patchset 2 (id:??) landed as
https://crrev.com/647dc9d1109f473f7cf069c3ba019dee5a4e062c
Cr-Commit-Position: refs/heads/master@{#436172}