Move Physical Web diagnostics page to new home

Move Physical Web diagnostics page to new home

This commit moves the Physical Web diagnostics page from
chrome://physical-web to chrome://physical-web-diagnostics

On iOS, chrome://physical-web points to a WebUI that lists Physical Web
URLs.  If we are to have some degree of parity in Android, the current
diagnostics page needs to move to a different location.

BUG=663842
Committed: https://crrev.com/eb10309884380d1b09d90e47ab854355453d1558
Cr-Commit-Position: refs/heads/master@{#435992}

[cco3, 2016-12-01 22:27:44]

cco3@chromium.org changed reviewers:
+ mattreynolds@chromium.org

[mattreynolds, 2016-12-01 22:40:12]

https://codereview.chromium.org/2547523003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java
(right):

https://codereview.chromium.org/2547523003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java:50:
@SuppressWarnings("deprecation")  // Update usage of Html.fromHtml when API min
is 24
Thanks!

https://codereview.chromium.org/2547523003/diff/1/components/physical_web/web...
File components/physical_web/webui/resources/physical_web.html (right):

https://codereview.chromium.org/2547523003/diff/1/components/physical_web/web...
components/physical_web/webui/resources/physical_web.html:10: <link
rel="stylesheet" href="chrome://physical-web-diagnostics/physical_web.css">
//components/physical_web/webui is for the iOS WebUI and shouldn't need any
changes for this CL.

[cco3, 2016-12-01 23:01:05]

https://codereview.chromium.org/2547523003/diff/1/components/physical_web/web...
File components/physical_web/webui/resources/physical_web.html (right):

https://codereview.chromium.org/2547523003/diff/1/components/physical_web/web...
components/physical_web/webui/resources/physical_web.html:10: <link
rel="stylesheet" href="chrome://physical-web-diagnostics/physical_web.css">
On 2016/12/01 22:40:12, mattreynolds wrote:
> //components/physical_web/webui is for the iOS WebUI and shouldn't need any
> changes for this CL.

Done.

[mattreynolds, 2016-12-01 23:13:49]

lgtm

[cco3, 2016-12-01 23:17:45]

Description was changed from

==========
Move Physical Web diagnostics page to new home

This commit moves the Physical Web diagnostics page from
chrome://physical-web to chrome://physical-web-diagnostics

On iOS, chrome://physical-web points to a WebUI that lists Physical Web
URLs.  If we are to do some degree of parity in Android, the current
diagnostics page needs to move to a different location.

BUG=663842
==========

to

==========
Move Physical Web diagnostics page to new home

This commit moves the Physical Web diagnostics page from
chrome://physical-web to chrome://physical-web-diagnostics

On iOS, chrome://physical-web points to a WebUI that lists Physical Web
URLs.  If we are to have some degree of parity in Android, the current
diagnostics page needs to move to a different location.

BUG=663842
==========

[cco3, 2016-12-01 23:18:18]

cco3@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[gone, 2016-12-02 00:12:08]

lgtm

[cco3, 2016-12-02 00:18:42]

The CQ bit was checked by cco3@chromium.org

[commit-bot: I haz the power, 2016-12-02 00:19:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 01:50:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 01:50:09]

Failed to apply patch for
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java:
While running git apply --index -p1;
  error: patch failed:
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java:47
  error:
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java:
patch does not apply

Patch:      
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java
Index:
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java
diff --git
a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java
b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java
index
244146225cbffd1993b4054b336b5c6827e28477..19737bac5e43b554c2301cd12e980d39ad24f8f9
100644
---
a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java
+++
b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java
@@ -47,6 +47,7 @@ public class PhysicalWebDiagnosticsPage extends
BasicNativePage {
     }
 
     @Override
+    @SuppressWarnings("deprecation")  // Update usage of Html.fromHtml when API
min is 24
     protected void initialize(final Activity activity, Tab tab) {
         Resources resources = activity.getResources();
         mSuccessColor =
colorToHexValue(ApiCompatibilityUtils.getColor(resources,
@@ -79,7 +80,7 @@ public class PhysicalWebDiagnosticsPage extends
BasicNativePage {
 
     @Override
     public String getHost() {
-        return UrlConstants.PHYSICAL_WEB_HOST;
+        return UrlConstants.PHYSICAL_WEB_DIAGNOSTICS_HOST;
     }
 
     @Override

[cco3, 2016-12-02 18:42:56]

The CQ bit was checked by cco3@chromium.org

[cco3, 2016-12-02 18:42:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org, mattreynolds@chromium.org
Link to the patchset: https://codereview.chromium.org/2547523003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-12-02 18:43:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 19:27:22]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480704176433800,
"parent_rev": "f7193808574d772971a58149e6edb0eda2ba00e5", "commit_rev":
"5523a73eacf9ae75e099ee66f6f8af05611b877e"}

[commit-bot: I haz the power, 2016-12-02 19:27:46]

Description was changed from

==========
Move Physical Web diagnostics page to new home

This commit moves the Physical Web diagnostics page from
chrome://physical-web to chrome://physical-web-diagnostics

On iOS, chrome://physical-web points to a WebUI that lists Physical Web
URLs.  If we are to have some degree of parity in Android, the current
diagnostics page needs to move to a different location.

BUG=663842
==========

to

==========
Move Physical Web diagnostics page to new home

This commit moves the Physical Web diagnostics page from
chrome://physical-web to chrome://physical-web-diagnostics

On iOS, chrome://physical-web points to a WebUI that lists Physical Web
URLs.  If we are to have some degree of parity in Android, the current
diagnostics page needs to move to a different location.

BUG=663842
==========

[commit-bot: I haz the power, 2016-12-02 19:27:47]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-02 19:30:41]

Description was changed from

==========
Move Physical Web diagnostics page to new home

This commit moves the Physical Web diagnostics page from
chrome://physical-web to chrome://physical-web-diagnostics

On iOS, chrome://physical-web points to a WebUI that lists Physical Web
URLs.  If we are to have some degree of parity in Android, the current
diagnostics page needs to move to a different location.

BUG=663842
==========

to

==========
Move Physical Web diagnostics page to new home

This commit moves the Physical Web diagnostics page from
chrome://physical-web to chrome://physical-web-diagnostics

On iOS, chrome://physical-web points to a WebUI that lists Physical Web
URLs.  If we are to have some degree of parity in Android, the current
diagnostics page needs to move to a different location.

BUG=663842

Committed: https://crrev.com/eb10309884380d1b09d90e47ab854355453d1558
Cr-Commit-Position: refs/heads/master@{#435992}
==========

[commit-bot: I haz the power, 2016-12-02 19:30:43]

Patchset 3 (id:??) landed as
https://crrev.com/eb10309884380d1b09d90e47ab854355453d1558
Cr-Commit-Position: refs/heads/master@{#435992}